enable early exit for fused_moe_lora#2
Merged
dcmaddix merged 2 commits intodcmaddix:marlin_experts_mxfp4from Oct 11, 2025
Merged
enable early exit for fused_moe_lora#2dcmaddix merged 2 commits intodcmaddix:marlin_experts_mxfp4from
dcmaddix merged 2 commits intodcmaddix:marlin_experts_mxfp4from
Conversation
This was referenced Oct 11, 2025
wcwuwc
reviewed
Oct 13, 2025
Comment on lines
+41
to
+44
| if (adapter_enabled[lora_id] * num_tokens_per_lora[lora_id] == 0) { | ||
| return; | ||
| } | ||
|
|
There was a problem hiding this comment.
I’m wondering why we don’t use activate_lora_ids[lora_idx] to check if LoRA is enabled here, and num_tokens_per_lora[lora_id] to determine if there are any tokens that need to be processed by the LoRA. Is there another consideration?
There was a problem hiding this comment.
the intention with adapter_enabled is to allow us to skip the moe_lora_align_sum_kernel if the LoRA model does not have MoE adapters (e.g. a LoRA model which only includes adapters for attn projections).
from my understanding, activate_lora_ids and num_tokens_per_lora only indicate if a LoRA model is being invoked, but does not indicate which specific LoRA kernels are applicable for that model
dcmaddix
pushed a commit
that referenced
this pull request
Jan 30, 2026
…3058) Signed-off-by: ramos <49182011+nemoramo@users.noreply.github.com> Signed-off-by: mayufeng <mayufeng@example.com> Co-authored-by: mayufeng <mayufeng@example.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.Purpose
Test Plan
Test Result
(Optional) Documentation Update