Re add removed jose package, add some testing and support for differe… #234
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request re-introduces the previously removed jose package, providing JWT and JWK functionality with support for multiple cryptographic key types. The implementation adds flexible key parsing utilities and JWT creation capabilities.
Key changes:
- Adds support for both EC (Elliptic Curve) and RSA private keys in multiple PEM formats (SEC1, PKCS1, PKCS8)
- Implements JWT signing functionality with configurable headers and claims
- Provides comprehensive test coverage for all key parsing and JWT creation functions
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| pkg/jose/jwk.go | Core implementation for parsing private keys (EC/RSA) and creating JWK representations, supporting multiple PEM formats |
| pkg/jose/jwk_test.go | Comprehensive test suite covering all key parsing functions with multiple key types and formats |
| pkg/jose/jwt.go | JWT creation function that signs tokens with custom headers and claims |
| pkg/jose/jwt_test.go | Test coverage for JWT creation including success and error cases |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
tummen upp från mig |
…nt keys.