Masv update credential proof #233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…proof for wallets not using the latest spec.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements Token Status List credential proof functionality, transitioning the registry from a Merkle tree-based system to a Token Status List implementation per the draft-ietf-oauth-status-list specification. Key changes include:
- Replaces the Sparse Merkle Tree registry with a Token Status List system for credential revocation tracking
- Implements JWT and CWT token generation for status lists with automatic caching and refresh
- Adds gRPC mTLS support with client certificate fingerprint verification
- Introduces an admin GUI for managing credential statuses
Reviewed changes
Copilot reviewed 103 out of 241 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| proto/v1-registry.proto | Updates registry service to support Token Status List operations instead of Merkle tree |
| proto/v1-issuer.proto | Adds token status list section/index fields to credential response |
| pkg/tokenstatuslist/*.go | New package implementing Token Status List JWT/CWT generation per draft-ietf-oauth-status-list |
| pkg/grpchelpers/*.go | New package for gRPC server/client helpers with mTLS and fingerprint verification |
| pkg/openid4vci/*.go | Refactors proof verification to support multiple proof types with type-safe structures |
| pkg/pki/pki.go | Enhances key parsing to support EC and RSA formats beyond PKCS#8 |
| internal/registry/tokenstatuslistissuer/*.go | New service for issuing and caching Token Status List tokens |
| internal/registry/db/*.go | Migrates from SQLite/GORM to MongoDB for Token Status List storage |
| internal/registry/httpserver/*.go | Adds Token Status List endpoints and admin GUI with authentication |
| internal/registry/grpcserver/*.go | Implements Token Status List gRPC endpoints with mTLS support |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.