Feature/go-trust #232
Merged
Feature/go-trust #232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
this pr also contains a new implementation of an authzen client for the go-trust server to be used for trust evaluation and did resolution |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR integrates the go-trust library for AuthZEN-based key resolution and trust evaluation, adding ECDSA support alongside existing Ed25519 functionality. The integration deprecates the local AuthZEN client in favor of the more feature-rich go-trust implementation.
Key changes:
- Added go-trust library dependency and created adapter components for key resolution
- Extended key resolver interfaces to support ECDSA keys in addition to Ed25519
- Implemented comprehensive test coverage for new functionality including JWK conversion, DID document parsing, and trust evaluation
Reviewed changes
Copilot reviewed 11 out of 1014 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Updated Go version to 1.25.1 and added go-trust dependency, removed testcontainers dependencies |
| pkg/keyresolver/resolver.go | Added ECDSAResolver interface and ResolveECDSA method to MultiResolver |
| pkg/keyresolver/gotrust_adapter.go | New adapter implementing key resolution using go-trust client with Ed25519 and ECDSA support |
| pkg/keyresolver/gotrust_adapter_test.go | Comprehensive tests for go-trust adapter including key resolution and trust evaluation |
| pkg/keyresolver/did_helpers.go | Helper functions for extracting keys from DID documents and entity configurations |
| pkg/keyresolver/did_helpers_test.go | Tests for DID document parsing and key extraction |
| pkg/keyresolver/authzen.go | Added GoTrustEvaluator and ECDSATrustEvaluator, deprecated local AuthZEN client |
| pkg/keyresolver/authzen_test.go | Tests for trust evaluation functionality |
| pkg/authzen/client.go | Added deprecation notice with migration guide |
| docs/adr/05-go-trust-authzen-client.md | Updated repository URL reference |
| docs/GO_TRUST_INTEGRATION_PLAN.md | Updated repository URL references |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
masv3971
reviewed
Dec 16, 2025
Contributor
Author
|
Pused fixes to the comments |
Implements go-trust library integration per GO_TRUST_INTEGRATION_PLAN.md: - Add GoTrustResolver adapter wrapping authzenclient for key resolution - Add ECDSAResolver interface extending Resolver for ECDSA support - Add DID document parsing helpers for extracting keys from trust_metadata - Add GoTrustEvaluator implementing ECDSATrustEvaluator interface - Add ValidatingResolver that combines resolution with trust evaluation - Add comprehensive tests achieving 80-100% coverage on new code The new integration provides: - Ed25519 and ECDSA key resolution via AuthZEN protocol - Trust evaluation with key extraction from response metadata - JWK conversion utilities for Ed25519 and ECDSA keys - DID document parsing for multikey and JWK formats Legacy AuthZENTrustEvaluator remains for backward compatibility. Old pkg/authzen package remains available but marked deprecated. Ref: ADR-05, GO_TRUST_INTEGRATION_PLAN.md
Remove the old pkg/authzen package and AuthZENTrustEvaluator that was kept for backwards compatibility. All code should now use the go-trust library (GoTrustEvaluator) instead. Changes: - Remove pkg/authzen/ directory entirely (client.go, README.md) - Remove AuthZENTrustEvaluator, NewAuthZENTrustEvaluator from keyresolver - Remove localAuthzen import from authzen.go - Remove deprecated tests for AuthZENTrustEvaluator
- Fix ECDSA trust evaluation to extract DID from verification method - Implement proper ECDSA multikey decoding with P-256 support - Refactor OpenID Federation parsing into smaller helper functions - Support both compressed (0x02/0x03) and uncompressed (0x04) EC points
- Update all imports from github.com/SUNET/go-trust to github.com/sirosfoundation/go-trust - Regenerate go.mod, go.sum and vendor directory
leifj
force-pushed
the
feature/rename-go-trust-to-sirosfoundation
branch
from
3ad451c to
a704aeb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.