Update to add parameter to drop-old-relations#107
Open
Benjamin-Knight wants to merge 1 commit intodbt-msft:mainfrom
Open
Update to add parameter to drop-old-relations#107Benjamin-Knight wants to merge 1 commit intodbt-msft:mainfrom
Benjamin-Knight wants to merge 1 commit intodbt-msft:mainfrom
Conversation
Add a new parameter to drop old relations macro which works the old way if the parameter is not provided. If provided allows toggling of the logging to the stdout.
Contributor
|
Os the pattern of comparing string_variable =='true' the typical way to handle Boolean Args in macros (I don't know but if there was a cleaner way I'd like it). Beyond that lgtm! |
Author
|
I was following the previous pattern of the macro which took a boolean flag as a string argument, not sure if there was a reason it was done that way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new parameter to drop old relations macro which works the old way if the parameter is not provided. If provided allows toggling of the logging to the stdout. closes #106