This repository was archived by the owner on Mar 1, 2021. It is now read-only.
Open
Conversation
standardize use of underscores and _line for variables
Standardize use of underscores in `billpayments_line_linkedtxn`
standardize use of suffix _line for base.invoices_line
|
Thanks for opening this PR @jordan8037310! I think your change is a good and sensible one, but it is definitely a breaking change. I don't have any issues with merging this though -- it will just need to ship as version Longer-term, I'd like to update this package to use a new strategy for declaring sources like the one shown here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated to follow the standard single underscore for variable naming and singular
_linesuffix.