Fix method _test_inside_point in global smooth boundary
#3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s unreliable, it fails for many points inside the boundary. * A test is written in an ipython notebook that can demonstrate this, see `tests/test_global_smooth_boundary.ipynb`. * The updated `_test_inside_point` method is now using the same algorithm as in `find_inside_points`, via`contains_points` method in the path object of matplotlib. Therefore, the boundary curve in GSB is also saved as a path (`self.poly`) during the initialization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method
_test_inside_pointin global smooth boundary is unreliable, it fails for many points inside the boundary.tests/test_global_smooth_boundary.ipynb._test_inside_pointmethod is now using the same algorithm as infind_inside_points, viacontains_pointsmethod in the path object of matplotlib. Therefore, the boundary curve in GSB is also saved as a path (self.poly) during the initialization.The pictures were generated with the
tests/test_global_smooth_boundary.ipynb.The red crosses are wrongly assigned points (marked "outside" even if they are inside) and blue crosses are correctly assigned points.
The updated method works reliably: