Set 'content-type' to 'application/vnd.api+json' as by specs#4
Open
mblackritter wants to merge 1 commit intodbrekalo:masterfrom
Open
Set 'content-type' to 'application/vnd.api+json' as by specs#4mblackritter wants to merge 1 commit intodbrekalo:masterfrom
mblackritter wants to merge 1 commit intodbrekalo:masterfrom
Conversation
mblackritter
changed the title
|
up. please merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@dbrekalo: Congrats for this well crafted *JSONAPI mocking solution, it's simply the most well thought solution out there, and I'm rather sure I tried them all. Didn't make use of the in-browser option so far, but that's a smart one and might get handy! 🤩🥳
As the specs require, this PR changes the header content-type from
application/jsontoapplication/vnd.api+jsonI ran into this while setting it up with Orbit JS, which just gave me a vague
TypeError: undefined is not an object (evaluating 'document.data') — jsonapi-serializer.js:128, until I found the issue being the content-type set to 'application/json'.* I generally tend to write JSONAPI, to make it distinkt from all that "something JSON API" out there.
Cheers,
Black