Open
Conversation
# Conflicts: # transact/src/test/java/dev/dbos/transact/workflow/WorkflowMgmtTest.java
Collaborator
|
FYI, I'm OOF at PASS this week and for Thanksgiving next week. This looks cool, but not sure when I'll have a chance to review. |
Collaborator
|
FYI, this looks good but I haven't made it work w/ my local environment (I'm running docker inside of WSL). Working on fixing this on my end - I can't merge approve this until I can confirm it works for me locally. |
Collaborator
|
Also note, the cli tests were not updated to use testcontainers. I will look at that after I update my environment to work w/ testcontainers. |
devhawk
reviewed
Dec 2, 2025
transact/build.gradle.kts
Outdated
| testImplementation("io.rest-assured:rest-assured:5.4.0") | ||
| testImplementation("io.rest-assured:json-path:5.4.0") | ||
| testImplementation("io.rest-assured:xml-path:5.4.0") | ||
| testImplementation("org.testcontainers:postgresql:1.21.3") |
Collaborator
There was a problem hiding this comment.
As per https://java.testcontainers.org/modules/databases/postgres/, this appears to be an outdated version
Resolved all merge conflicts by keeping testcontainers setup: - All tests now extend DbSetupTestBase and use testcontainers - Updated build.gradle.kts to include both testcontainers and maven-artifact dependencies - Added dataSource field to DbSetupTestBase for tests that need direct database access - Converted 6 new test files to use DbSetupTestBase: * MetricsTest * SingleExecutionTest * PatchTest * PartitionedQueuesTest * ForkTest * GarbageCollectionTest
Collaborator
|
FYI, I'm working on some db connection changes. Might make sense to give your updates a day or two |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add testcontainers as test dependency for the setup of a Postgresql instance for testing. This allows running the tests on a local machine. The only requirement is Docker.
This PR also moves the setup of the DB connection into a common base class.