Skip to content

Feature/ATF Script Runner#2

Open
dboltovskyi wants to merge 15 commits intodevelopfrom
feature/atf_parallels
Open

Feature/ATF Script Runner#2
dboltovskyi wants to merge 15 commits intodevelopfrom
feature/atf_parallels

Conversation

@dboltovskyi
Copy link
Owner

PR for internal review of SDL-0128 ATF Script Runner proposal

@dboltovskyi dboltovskyi force-pushed the feature/atf_parallels branch from dc6da99 to 5d7de34 Compare July 1, 2020 16:12
README.md Outdated
- Run `make install`

**4.** Copy content of scripts repository
- Run `cp -r <path_to_sdl_atf_test_scripts>/* .`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dboltovskyi maybe better to propose an alternative and to create a soft links?

README.md Outdated
- folder with test scripts
- [OPTIONS] - options supported by ATF:
- --sdl-core - path to SDL binaries
- --config - name of configuration

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dboltovskyi is it really a name? Maybe it is also a path to some config file?

README.md Outdated
- test set
- folder with test scripts
- [OPTIONS] - options supported by ATF:
- --sdl-core - path to SDL binaries

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- --sdl-core - path to SDL binaries
- --sdl-core <path> - path to SDL binaries

README.md Outdated
- [OPTIONS] - options supported by ATF:
- --sdl-core - path to SDL binaries
- --config - name of configuration
- --sdl-api - path to SDL APIs

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- --sdl-api - path to SDL APIs
- --sdl-api <path> - path to SDL APIs

README.md Outdated
- --sdl-core - path to SDL binaries
- --config - name of configuration
- --sdl-api - path to SDL APIs
- --report - path to report and logs

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- --report - path to report and logs
- --report <path> - path to report and logs

}

function prepare_queue {
if [ -f "$_queue" ];then

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dboltovskyi probably its nice to add a description here as well

}

function mktemptdir {
tmpdirname=$(mktemp --suffix=_worker --tmpdir=$_tmp_dir -d)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dboltovskyi and here

#############################################################

function int_handler {
echo "Please, wait for subprocesses to be buried alive."

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dboltovskyi nice kek :) but for production its better to rephrase

_tmp_workers=$(echo $_tmp_workers" $screen_basename" | xargs)
done

log "Workers are running. Waiting termination..."

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
log "Workers are running. Waiting termination..."
log "Workers are running. Waiting for termination..."

dummy() { :; }

kill_sdl() {
dummy

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dboltovskyi is this file has a role of placeholder in terms of current proposal? Maybe it will be good to leave a TODO comment here?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is by design since remote runner is based on common one. However all these functions implemented in common have no sense for remote mode and have to be 'disabled'.

@dboltovskyi
Copy link
Owner Author

@AKalinich-Luxoft Please find updates in e1484c8 - fd3133e

@dboltovskyi dboltovskyi force-pushed the feature/atf_parallels branch from ad32fd2 to 8b71811 Compare July 17, 2020 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants