Conversation
Bumps [jspdf](https://github.com/parallax/jsPDF) from 1.3.5 to 4.1.0. - [Release notes](https://github.com/parallax/jsPDF/releases) - [Changelog](https://github.com/parallax/jsPDF/blob/master/RELEASE.md) - [Commits](parallax/jsPDF@v1.3.5...v4.1.0) --- updated-dependencies: - dependency-name: jspdf dependency-version: 4.1.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
| "interact.js": "~1.2.6", | ||
| "jcanvas": "~16.7.3", | ||
| "jspdf": "~1.3.2", | ||
| "jspdf": "~4.1.0", |
There was a problem hiding this comment.
Bug: The jsPDF upgrade to v4.1.0 introduces a breaking change. The code still calls the removed setFontType() method, which will cause a crash when printing legends.
Severity: CRITICAL
Suggested Fix
The separate calls to doc.setFont(style.font) and doc.setFontType(style.fontType) should be combined into a single call that is compatible with the new jsPDF API: doc.setFont(style.font, style.fontType).
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: package.json#L74
Potential issue: The pull request upgrades `jsPDF` from version 1.3.x to 4.1.0. This
upgrade introduces a breaking change, as the `setFontType()` method was removed in
version 2.0.0. The code in `src/components/layers/layerlegends.vue` at line 269 still
calls `doc.setFontType(style.fontType)` when generating a PDF for printing legends. This
will result in a `TypeError: doc.setFontType is not a function` and crash the
application whenever a user attempts to use the print functionality in the legends
panel.
Did we get this right? 👍 / 👎 to inform future reviews.
Bumps jspdf from 1.3.5 to 4.1.0.
Release notes
Sourced from jspdf's releases.
... (truncated)
Commits
02273814.1.0ae4b93fMerge commit from fork2863e5cMerge commit from forkefe54bfMerge commit from forkda291a5Merge commit from fork685e41eBump@koa/corsand local-web-server (#3951)8cc22a5Bump tmp, inquirer and karma (#3945)008b276Bump sha.js from 2.4.11 to 2.4.12 (#3946)ff66d52Bump vite from 5.4.20 to 5.4.21 in /examples/vite (#3949)bcf79f2Bump cipher-base from 1.0.4 to 1.0.7 (#3942)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.