changing toml library to rtoml for TOML 1.0 support #365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
May 16, 2025 13:13
Author
|
The reason why the Tests action workflow fails is because actions/upload-artifact@v3 is deprecated since November 30, 2024. As per their readme, I bumped the version to v4. |
Owner
|
Ok looks like the CI is a bit messed up at the moment, might need a bigger refresh. Will try and take a look at it soon |
Contributor
|
tomllib is in the standard library, which is convenient |
Owner
|
Closing as we should now support TOML 1.0 via the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"toml" version 0.10.2 does not support TOML 1.0 as explained in the issue #364.
I took the liberty to use the rtoml library not tomllib since rtoml is more recent and is quite fast as it is written in rust.