Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces a PostgreSQL materialized view to precompute cumulative team scores per round, reducing query cost for score graph endpoints.
Changes:
- Add
cumulative_scoresmaterialized view + unique index during DB connect. - Switch cumulative score-by-round query to read from the materialized view instead of running a window function per request.
- Refresh the materialized view after each round (asynchronously) and after score resets.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| engine/engine.go | Triggers an async refresh of the cumulative scores materialized view after processing each round. |
| engine/db/servicechecks.go | Reads cumulative scores from cumulative_scores instead of computing via a window function on each call. |
| engine/db/rounds.go | Adds RefreshScoresMaterializedView() helper with concurrent refresh when possible. |
| engine/db/db.go | Creates the cumulative_scores materialized view and index at startup; refreshes it during ResetScores(). |
| IMPLEMENTATION_SUMMARY.md | Documents the materialized view approach, refresh strategy, and rationale. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Looks good to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.