Skip to content

Conversation

@dbarzin
Copy link
Owner

@dbarzin dbarzin commented Dec 30, 2025

Summary by CodeRabbit

  • Chores

    • Bumped app and package version to 2025.12.30
    • Updated mercator-core dependency version
  • Removed

    • Removed several module management CLI commands (install, enable, disable, uninstall, list) and their registrations
  • Config

    • Replaced the module service provider with an updated Mercator provider
  • Localization

    • Added uninstall confirmation translations (en/fr)

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 30, 2025

Walkthrough

Updated the Mercator core dependency version, removed several Artisan module-management commands, switched a Mercator service provider entry in config, bumped package/version files, and added uninstall confirmation translations in English and French.

Changes

Cohort / File(s) Summary
Composer dependency
composer.json
Bumped sourcentis/mercator-core requirement from ^1.21 to ^1.24.
Version files
package.json, version.txt
Package/version bumped from 2025.12.15 to 2025.12.30.
Console commands (removed)
app/Console/Commands/MercatorModuleInstall.php, app/Console/Commands/MercatorModuleUninstall.php, app/Console/Commands/MercatorModuleEnable.php, app/Console/Commands/MercatorModuleDisable.php, app/Console/Commands/MercatorModulesList.php
Deleted Laravel Artisan command classes and their handle logic for installing, uninstalling, enabling, disabling, and listing Mercator modules.
Kernel command registration
app/Console/Kernel.php
Removed registrations of the above Mercator module commands from the $commands array (other commands left intact).
Config provider change
config/app.php
Replaced provider entry Mercator\Core\Providers\LicenseServiceProvider::class with Mercator\Core\Providers\MercatorServiceProvider::class.
Localization additions
resources/lang/en/cruds.php, resources/lang/fr/cruds.php
Added module.labels.confirm_uninstall translations: English "Do you want to uninstall this module?" and French "Voulez-vous désinstaller ce module ?".

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

🐰 I hopped across commits with a twitchy nose,

Commands that managed modules quietly doze.
Versions nudged forward, a provider swapped place,
Two tiny translations—polite uninstall grace.
A rabbit applauds this neat little pace.

Pre-merge checks

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'build' is vague and generic, providing no meaningful information about the changeset. It does not convey the primary changes: dependency updates, command removals, service provider replacement, or translations. Use a more descriptive title that summarizes the main changes, such as 'Remove Mercator module CLI commands and update dependencies' or 'Refactor module management and update service providers'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 0d96ea6 and f751069.

⛔ Files ignored due to path filters (1)
  • composer.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • composer.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • composer.json

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
app/Console/Kernel.php (1)

13-18: Add CHANGELOG entry documenting the removal of module management Artisan commands.

The removal of the four module management commands (mercator:module-install, mercator:module-enable, mercator:module-disable, mercator:module-uninstall) is well-architected: no external references exist, and full UI-based alternative functionality is already implemented in ModuleController with corresponding routes and views. However, this breaking change is not documented in CHANGELOG.md. Add an entry explaining that users should use the web UI for module management going forward.

📜 Review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 950565e and 0d96ea6.

⛔ Files ignored due to path filters (1)
  • composer.lock is excluded by !**/*.lock
📒 Files selected for processing (10)
  • app/Console/Commands/MercatorModuleDisable.php
  • app/Console/Commands/MercatorModuleEnable.php
  • app/Console/Commands/MercatorModuleInstall.php
  • app/Console/Commands/MercatorModuleUninstall.php
  • app/Console/Commands/MercatorModulesList.php
  • app/Console/Kernel.php
  • composer.json
  • config/app.php
  • resources/lang/en/cruds.php
  • resources/lang/fr/cruds.php
💤 Files with no reviewable changes (5)
  • app/Console/Commands/MercatorModuleEnable.php
  • app/Console/Commands/MercatorModuleInstall.php
  • app/Console/Commands/MercatorModuleDisable.php
  • app/Console/Commands/MercatorModuleUninstall.php
  • app/Console/Commands/MercatorModulesList.php
🚧 Files skipped from review as they are similar to previous changes (1)
  • composer.json
🔇 Additional comments (3)
resources/lang/fr/cruds.php (1)

1017-1018: LGTM!

The French translation for the module uninstall confirmation is correctly added and grammatically accurate.

resources/lang/en/cruds.php (1)

964-965: LGTM!

The English translation for the module uninstall confirmation is clear and properly structured.

config/app.php (1)

235-235: [rewritten review comment]
[exactly one classification tag]

@dbarzin dbarzin merged commit cebbbea into master Jan 2, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants