This repository was archived by the owner on Jun 14, 2019. It is now read-only.
Thorough code review request #19
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 144300f.
dbaltas
changed the title
mantzas
reviewed
Mar 8, 2019
Collaborator
mantzas
left a comment
mantzas
left a comment
There was a problem hiding this comment.
a lot of code inside every command action.
I had reviewed this in the past too so no major issues found...
this is too big to review at once...
| @@ -0,0 +1,159 @@ | |||
| package cmd | |||
Collaborator
There was a problem hiding this comment.
We should create component here. deploy branches does too much.
the command should only get the argument needed to call the components...
We should separate the ux from the business code...
| fmt.Println(resp) | ||
| fmt.Println(repo.Name) | ||
|
|
||
| // tagName := "2018.04.19" |
| @@ -0,0 +1,87 @@ | |||
| package cmd | |||
Collaborator
There was a problem hiding this comment.
we should implement the tag compare too since some of us deploy based on tag
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 144300f.