Skip to content

Conversation

@dazuma
Copy link
Owner

@dazuma dazuma commented Jan 5, 2026

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for running the Ractor::Wrapper sequentially without worker threads, changing the default behavior from single-threaded to sequential execution mode.

  • Changes the default threads parameter from 1 to 0, disabling worker threads by default
  • Implements sequential execution logic that handles method calls directly in the main loop when threads are disabled
  • Expands test coverage to verify all functionality works in both sequential (threads: 0) and threaded (threads: 2) modes

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
lib/ractor/wrapper.rb Implements sequential execution mode, updates default threads parameter to 0, adds port closing for resource cleanup, changes send to __send__ for more robust method invocation, and updates documentation to reflect new threading model
test/test_wrapper.rb Restructures tests to run with both sequential and threaded configurations, ensuring comprehensive coverage of all wrapper behaviors in both modes
README.md Updates documentation to clarify threading model caveats and align with code changes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dazuma dazuma merged commit a9eb4ae into main Jan 5, 2026
3 checks passed
@dazuma dazuma deleted the pr/nothreads branch January 5, 2026 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants