Skip to content

Conversation

@dazuma
Copy link
Owner

@dazuma dazuma commented Jan 3, 2026

No description provided.

@dazuma dazuma force-pushed the pr/ruby4 branch 2 times, most recently from d8b6709 to f0c630a Compare January 3, 2026 18:07
@dazuma dazuma requested a review from Copilot January 3, 2026 18:08
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request aims to update the ractor-wrapper gem for Ruby 4.0, introducing significant API changes and new features. However, Ruby 4.0 does not exist yet (the latest stable version is Ruby 3.3.x as of January 2025), which makes this update premature and will prevent the gem from being used in any current Ruby version.

Key changes include:

  • Updating Ruby version requirement from 3.0 to 4.0 (nonexistent version)
  • Adding frozen_string_literal: true pragmas to all Ruby files
  • Renaming methods (threadsthread_count, logginglogging_enabled, recovered_objectrecover_object, move_returnmove_result)
  • Adding new block execution features with execute_block_in_ractor option
  • Introducing new Ruby 4.0 APIs like Ractor::Port, Ractor.shareable_proc, and Ractor#value
  • Updating test infrastructure and dependencies

Reviewed changes

Copilot reviewed 14 out of 15 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
ractor-wrapper.gemspec Updated Ruby version requirement to 4.0 (critical: version doesn't exist), improved description
lib/ractor/wrapper/version.rb Added frozen_string_literal pragma, removed redundant .freeze on VERSION
lib/ractor/wrapper.rb Major refactoring with API renames, new block execution features, bug fix in cleanup_phase needed (line 685-686), spelling error on line 576
lib/ractor-wrapper.rb Added frozen_string_literal pragma
test/test_wrapper.rb Added frozen_string_literal pragma, updated tests for new API, added block execution tests
test/test_example.rb New test file for README and SQLite3 examples
test/helper.rb Added frozen_string_literal pragma, renamed failwhoops, added helper methods
test/data/numbers.db New SQLite database file for tests
README.md Updated documentation for Ruby 4.0 APIs and new features, future copyright year (2026)
LICENSE.md Updated copyright year to 2021-2026 (includes future year)
Gemfile Updated dependencies to possibly nonexistent versions (minitest 6.0, potentially faraday 2.14, sqlite3 2.9)
.toys/ci.rb New CI tool configuration
.toys/.toys.rb Removed inline CI tool definition, added frozen_string_literal pragma
.rubocop.yml Extensive rubocop configuration updates targeting Ruby 4.0
.github/workflows/ci.yml Updated CI workflow to use Ruby 4.0 (will fail)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dazuma dazuma merged commit b7a3c68 into main Jan 3, 2026
3 checks passed
@dazuma dazuma deleted the pr/ruby4 branch January 5, 2026 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants