-
Notifications
You must be signed in to change notification settings - Fork 44
GPU utilization in Daytona for LLM fine-tuning and inference #141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d3f651b to
3c81cf6
Compare
|
Happy new year @mojafa please this PR is ready for review |
c74553e to
62fce04
Compare
|
@mojafa could you please review this PR as I want to open for another issue. |
|
@stdthoth apologies, just to let you know there's another PR that also tackles the same issue. I'm reviewing all of them and will assign the one with the best quality. |
|
@mojafa no problem.. take your time and I am available for any clarifications |
|
Any updates concerning the review @mojafa |
|
@stdthoth Just to let you know, someone else was assigned this task but had to close their PR as he had attempted more than one issue. I'll also check for code similarity. I'm reviewing your PR now, and if it's sufficient, I'll assign this to you. |
|
@stdthoth please link keywords in most of your paragraphs, from intro all the way down.. it's very plain and some terms like GPU should be linked as a keyword. |
|
Also, your TL/DR section is not supposed to be there. I'll test the code, but please ensure that your article follows the template. Equally, this is an article, not a guide, according to the issue: #8 |
Signed-off-by: stdthoth <ichthoth@gmail.com>
…in GPU utilization guide Signed-off-by: stdthoth <ichthoth@gmail.com>
Signed-off-by: stdthoth <ichthoth@gmail.com>
Signed-off-by: stdthoth <ichthoth@gmail.com>
Signed-off-by: stdthoth <ichthoth@gmail.com>
Signed-off-by: stdthoth <ichthoth@gmail.com>
Signed-off-by: stdthoth <ichthoth@gmail.com>
…ver, and LLM inference and added as keyword in article Signed-off-by: stdthoth <ichthoth@gmail.com>
4ae7386 to
51932d1
Compare
Signed-off-by: stdthoth <ichthoth@gmail.com>
|
|
@mojafa any updates on this ?? |
|
@stdthoth allow me to re-review this over the next 2 days |
|
@mojafa okay thanks 👍🏽 |
|
@mojafa any updates ?? |
|
@stdthoth reviewing now |
|
@stdthoth I've assigned this issue to you. However, I'll need more time as i need to provision a GPU based machine to run nvidia. In the meantime, please share your screen recording of your solution. The content of the article lokos good. |
|
@mojafa sent |
|
@stdthoth I managed to spin up a GPU enabled VM but I'm facing some issues. I feel like your article jumps directly into the technical steps without providing some essential context upfront, such as system architecture requirements and prerequisites. My suggestions:
Revised Example Intro:Prerequisites and System ArchitectureBefore starting the setup process for GPU-based LLM fine-tuning and inference with Daytona, ensure your system meets the following requirements: Hardware:
Software:
Environment:
somthing like: This way, the reader gets a full picture right from the start! |
|
@stdthoth running into this error. Looks like the image is outdated. I'll find a workaroudn or fix as well. |
|
@stdthoth please hvae a look at your dev configs, running Please test lo
|
|
@mojafa already making edits |
Signed-off-by: stdthoth <ichthoth@gmail.com>
|
@mojafa I have made all the necessary changes you requested 👌🏽 |
|
@mojafa concerning the workspace failing to start. I made a mistake with the name of the .txt file with which the llm uses for fine-tuning.. please change |
Signed-off-by: stdthoth <ichthoth@gmail.com>
|
I have tried reading the article, but it is not the expected quality. It is hard to read, and the introduction misses the point. Please read the connected issue and think about how to rewrite the article more fluently. utilization ...and not "a percentage of a [GPU's]" - this is nonsense.... I appreciate the hard work, but this needs to be properly written, have a narrative and a story arc. And in the end make sense. @stdthoth |
|
due to the low quality of writing and no response I have to close this, thanks |
|
@nkko I am currently working on this, can you please reopen.. I'll have something by tomorrow |





/claim #8
Writer's Checklist
Writing Structure
(use this tool)
section.
TLDRs, and key points.
code elementsandMarkdown formatwhere appropriate.(screenshots, diagrams, tables, graphs, lists, sidenotes, blockquotes).
Fact-Checking
Asset Management
/assetsfolder.YYYYMMDD_title_of_the_article_IMG_NAME_NO.png.share it.
Interlinking
CTRL+Fto search for relevant keywords in:Glossary/Definitions
/defitnitionsfolder.Review and Edit
intent.
grammar tool.