feat(mermaid-tools): add macOS support with auto-detection#23
Open
gucs wants to merge 1 commit intodaymade:mainfrom
Open
feat(mermaid-tools): add macOS support with auto-detection#23gucs wants to merge 1 commit intodaymade:mainfrom
gucs wants to merge 1 commit intodaymade:mainfrom
Conversation
Add OS detection to extract-and-generate.sh script to support both macOS and WSL2/Linux. Includes platform-specific Chrome paths, separate Puppeteer configs for each OS, and updated documentation with macOS installation instructions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(mermaid-tools): add macOS support with auto-detection
Description
Add OS detection to extract-and-generate.sh script to support both macOS and WSL2/Linux. Includes platform-specific Chrome paths, separate Puppeteer configs for each OS, and updated documentation with macOS installation instructions.
Type of Change
Related Issues
Fixes #
Relates to #
Changes Made
Detailed list of changes:
unamebased OS detection inextract-and-generate.shto distinguish between macOS and Linux/WSL2./Applications/Google Chrome.app/...) and Linux/WSL2.statcommand between BSD (macOS) and GNU (Linux) for file size validation.puppeteer-config-macos.jsonwith optimized arguments for running Puppeteer on macOS.SKILL.mdwith comprehensive macOS installation instructions using Homebrew.Affected Skills
Which skills are affected by this PR?
Testing Done
How has this been tested?
Test description:
extract-and-generate.shcorrectly identifies macOS and locates Chrome.statcommand output on macOS for file size checks.Quality Checklist
For All PRs
For Documentation Changes