Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 의 종류는 어떤 것인가요?
수정이 필요하게된 이유가 무엇인가요? (Jira 이슈가 있다면 링크를 연결해주세요)
현대이지웰에서 사용하는 SEED 구현이 박살나있음
시중에 돌아다니는 구현 중에 맞는 것이 없어서 저쪽에서 제공한 Java 코드를 TypeScript로 포팅
코드 변경을 이해하기 위한 배경지식이 필요하다면 설명 해주세요.
SEED가 아니라고 생각하면 편합니ㄷㅏ
디펜던시 변경이 있나요?
crypto-util에 존재하던 crypto.js 카피를 삭제함
어떻게 테스트 하셨나요?
crypto-util.spec.ts
코드의 실행결과를 볼 수 있는 로그나 이미지가 있다면 첨부해주세요.
–