-
Notifications
You must be signed in to change notification settings - Fork 2
feat: 여러 동작을 실행하는 경우 multi를 사용하도록 변경 #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -219,15 +219,20 @@ export class FastCache { | |
| return { | ||
| key, | ||
| add: async (score: number, value: string): Promise<void> => { | ||
| await this.client.zadd(key, score, value); | ||
| const multi = this.client.multi(); | ||
| multi.zadd(key, score, value); | ||
| multi.expire(key, this.ttl); | ||
| await multi.exec(); | ||
| }, | ||
| addAll: async (entries: Array<{ score: number; value: string }>): Promise<void> => { | ||
| if (entries.length === 0) { | ||
| return; | ||
| } | ||
|
|
||
| const args = entries.flatMap((entry) => [entry.score, entry.value]); | ||
| await this.client.zadd(key, ...args); | ||
| const multi = this.client.multi(); | ||
| multi.zadd(key, ...args); | ||
| multi.expire(key, this.ttl); | ||
| await multi.exec(); | ||
| }, | ||
| remove: async (...values: Array<string>): Promise<void> => { | ||
| await this.client.zrem(key, ...values); | ||
|
|
@@ -308,12 +313,13 @@ export class FastCache { | |
| throw new Error('score is not a number'); | ||
| } | ||
|
|
||
| const tempKey = `${key}:temp:${Date.now()}`; | ||
|
|
||
| const args = entries.flatMap((entry) => [entry.score, entry.value]); | ||
| await this.client.zadd(tempKey, ...args); | ||
| await this.client.expire(tempKey, 60); | ||
| await this.client.rename(tempKey, key); | ||
|
|
||
| const multi = this.client.multi(); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 데이터베이스 트랜젝션처럼 처리하는군요~ api 디자인이 일관성이 생겨서 좋은 거 같습니다. |
||
| multi.del(key); | ||
| multi.zadd(key, ...args); | ||
| multi.expire(key, this.ttl); | ||
| await multi.exec(); | ||
| }, | ||
| }; | ||
| } | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 경우 (single add)에도 multi 를 사용하는거에요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
네 single add에도 expire로 ttl을 설정해주다보니 transaction 처럼 multi를 사용해두었습니다!