Merged
Conversation
soomtong
approved these changes
May 19, 2025
anniemon
reviewed
May 20, 2025
src/FastCache.spec.ts
Outdated
| { score: 300, value: 'baz' }, | ||
| ]); | ||
|
|
||
| const result = await sortedSet.range({ start: 0, stop: 2, withScores: true }); |
There was a problem hiding this comment.
Score없이 조회하면 withScores가 false여야하는 거 아닐지요?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 의 종류는 어떤 것인가요?
수정이 필요하게된 이유가 무엇인가요? (Jira 이슈가 있다면 링크를 연결해주세요)
콜로소에서 인기순으로 게시물(포트폴리오)를 정렬하기 위해 sorted set을 추가합니다.
api docs: https://redis.io/docs/latest/develop/data-types/sorted-sets/
사용하고자 하는 flow
무엇을 어떻게 변경했나요?
코드 변경을 이해하기 위한 배경지식이 필요하다면 설명 해주세요.
디펜던시 변경이 있나요?
어떻게 테스트 하셨나요?
테스트 코드
코드의 실행결과를 볼 수 있는 로그나 이미지가 있다면 첨부해주세요.