strip trailing slashes from URL before rerouting#14
strip trailing slashes from URL before rerouting#14nickautomatic wants to merge 2 commits intodavist11:masterfrom
Conversation
… routed the same way as /page). fixes davist11#13
|
👍 whatchyu think @davist11? |
|
Isn't this one worth merging? |
|
Is this one going to get merged? |
|
Most likely no. Don't want to break existing installs and this add-on likely won't get updated for Craft 3 since https://github.com/nystudio107/retour has since come out and is more full-featured. |
|
@davist11 You're definitely right to be cautious about not breaking things, but in this case it's difficult to imagine what would be likely to be broken by merging this: the only situation I can think of where it would cause unintended consequences is the situation where someone was deliberately routing, eg. So personally I think merging this pull request should be safe, and is likely to help most users and be unlikely to hinder anyone. Obviously it's your call though, and understandable if you don't have time to spend on a (very handy!) plugin you made quite a while ago. |
(to ensure /page/ is routed the same way as /page). Fixes #13