add labels option #230
Open
add labels option #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
This is the more complex and complete alternative to #229. I actually like this one better and would prefer this version to be merged! |
RoadRunnr
force-pushed
the
feature/labels
branch
2 times, most recently
from
cb0f8ba to
a2ca7fd
Compare
Add a `{labels, Labels}` with `Label = binary | atom | existing_atom | attempt_atom` to control
the how JSON labels are returned during decoding.
The NIF API only added support for UTF-8 atom in OTP-26. Use it to properly encode and decode atoms.
RoadRunnr
force-pushed
the
feature/labels
branch
from
b45c041 to
3573753
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
{labels, Labels}withLabel = binary | atom | existing_atom | attempt_atomto control the how JSON labels are returned during decoding.