Skip to content

Big refactoring adding best practices#1

Open
arojunior wants to merge 24 commits intodavidtran:masterfrom
arojunior:master
Open

Big refactoring adding best practices#1
arojunior wants to merge 24 commits intodavidtran:masterfrom
arojunior:master

Conversation

@arojunior
Copy link

@arojunior arojunior commented Apr 28, 2017

Actually, there is nothing "wrong" with your code, but it can be better. This PR is following the best practices and using another two libs to make things easier.

I hope you like it.

Copy link

@Hipjea Hipjea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
Can you please explain me the 'modules/Login/PENDING' pattern in :
const SET_LOGIN_PENDING = 'modules/Login/PENDING'

@arojunior
Copy link
Author

Hi, @Hipjea

I had forgot about this PR, thank you for to be interested.
So, it is using a pattern called "redux ducks" and you can find the explanation here: https://github.com/erikras/ducks-modular-redux#example

Let me know if I can help you with something more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants