Skip to content

Bugfix: add field-insensitive information upon reaching a field-sensitive store #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jordr wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bugfix: add field-insensitive information upon reaching a field-sensitive store #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1eb3f6f
Add failing unit test for intersection of field-sensitive and field-i…
jordr Apr 3, 2020
88b2a38
Add field-insensitive information upon reaching a field-sensitive store
jordr Mar 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions lib/Analysis/ModRefAnalysis.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,15 @@ void ModRefAnalysis::addStore(
assert(false);
}

// if nodeId is field-sensitive, add field-insensitive info too
bool insensitive = aa->getPTA()->getFIObjNode(nodeId) == nodeId;
if(!insensitive) {
NodeID FInodeId = aa->getPTA()->getFIObjNode(nodeId);
pair<Function *, NodeID> k = make_pair(f, FInodeId);
objToStoreMap[k].insert(store);
modPts.set(FInodeId);
}

/* TODO: check static objects? */
if (obj->getMemObj()->isStack()) {
const Value *value = obj->getMemObj()->getRefVal();
Expand Down
32 changes: 32 additions & 0 deletions test/Slicing/field-sensitivity-hetero.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
// RUN: %llvmgcc %s -emit-llvm -O0 -c -o %t1.bc
// RUN: rm -rf %t.klee-out
// RUN: %klee --skip-functions=foo --output-dir=%t.klee-out %t1.bc > %t2.out 2> %t2.out
// RUN: FileCheck %s -input-file=%t2.out
// RUN: test ! -f %t.klee-out/test000001.ptr.err

// CHECK: 1 (good!)
// CHECK: recovery states = 2
// CHECK-NOT: (bad!)

#include <stdio.h>

int off = 0;
char* file = "12";

void foo(char *x) {
x[0] = file[off++];
}

void bar(char* x) {
x[0] = file[off++];
}

int main(int argc, char** argv) {
char a, b;
foo(&a);
bar(&b);

if (a == '1')
printf("1 (good!)\n");
else printf("%d (bad!)\n", a);
}