Update to work with the latest crates#5
Update to work with the latest crates#5panicbit wants to merge 8 commits intodavidrhyswhite:masterfrom
Conversation
| Ok(Firebase { | ||
| url: Arc::new(url), | ||
| }) | ||
| Firebase::from_url(url) |
There was a problem hiding this comment.
I like this refactor 👍
|
Hi @panicbit thanks for the PR! |
|
I decided to switch to |
|
It is because |
|
I'm not using Windows primarily but AFAIK setting up native dependencies is a pain. |
|
Oh so we shouldn't depend on |
|
I'm not saying that you shouldn't, but I guess it would be nice to gradually move towards pure Rust crates. Hyper sadly still has a dependency on |
|
You're right that pure rust crates are ideal, I'll think about it and get back to you. |
| let opts = vec![ (AUTH, auth_token) ]; | ||
| url.set_query_from_pairs(opts.into_iter()); | ||
| let mut url = try!(Url::parse(&url)); | ||
| url.query_pairs_mut().append_pair(AUTH, auth_token).finish(); |
|
I cannot build this. |
|
For my own crate, I've switched to using |
This change is