Fix invalid battery entities for HV, add missing BMS and battery entities ❘ Deye 3P #906
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is quite a big rework of the whole Deye 3P battery definition.
Secondary batteries are not tested, and also BMS 2 batteries are still not there because it's already extremely long.
I feel like 20 batteries are excessive, but that's how many there were originally, so I kept them. I could not find any information about how many batteries they support.
Old definitions are kept with a modifier.
There are also some things I don't necessarily like, for example how the battery entities are all named sensor.battery_name_battery_1_xxx - the battery_1 feels redundant. I was not able to change them without touching the entity creation code, so I left it as is.
Additionally the Battery Life Cycle counters are off by one decimal point, counting 10 every time the battery is fully charged from emtpy, but they are defined deeper in the code and might be correct for other devices. However, the BMS also calculates it so the entity is totally unnecessary.
The values of all modified entities are confirmed to match with Solarman Cloud.
To note that I created this branch only after the other pull request, so this contains those changes as well.
Opening as a draft because I am unable to test the old entities and because some functions seem to assume there is only one BMS/cluster (like the Life Cycles entities).
Fixes #773 and maybe #896 as well (added all missing battery entities that are available).
Feedback wanted:
suggested_display_precision: 0does not work? The inverter does not count decimals for some values and displaying them is unnecessary.