Collect timeout feature#239
Merged
mcollina merged 13 commits intodavidmarkclements:masterfrom Aug 21, 2021
TryGhost:collect_timeout_new
Merged
Collect timeout feature#239mcollina merged 13 commits intodavidmarkclements:masterfrom TryGhost:collect_timeout_new
mcollina merged 13 commits intodavidmarkclements:masterfrom
TryGhost:collect_timeout_new
Conversation
- seems like this only needs to happen once, outside of the stream function
Closed
Collaborator
|
Thanks! |
Contributor
Author
|
Thank you ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original PR is here: #222
This has the effect of only rendering flamegraphs with data after the delay ends.
This solves some use cases of #129.
My own use case is not wanting to see output from the initial boot of my app (different problem, distracting!) but rather focus on what happens when requests are received.
I am aware the code is untested, keen for some input on where to start with adding tests as the critical affected code in lib/v8-log-to-ticks.js appears to be as yet untested as far as I can tell.