Skip to content

Conversation

@shanto
Copy link

@shanto shanto commented Nov 11, 2011

No description provided.

@davidiw
Copy link
Owner

davidiw commented Nov 15, 2011

Hey Shanto, I've forwarded this to folks at UF. We have some people there with NSIS background. I have been extremely and continuously busy since the beginning of October.

A couple of comments:

  • Your scripts require using wine, I think that is very atypical usage, perhaps the best way would be to have a script that could be either called by wine or directly in Windows
  • You are bundling dll files and other generated files, the license on those is unclear. I'd prefer a short writeup on how to download NSIS in order to build the installable files rather than bundle these files.

Thanks for your efforts!

David

@shanto
Copy link
Author

shanto commented Nov 15, 2011

Hey David, I knew you were busy with your current projects, so no explanation was expected :). Anyway, let me clarify on wine and bundled dll files:

  • The Makefile (with wine command) is there just for convenience. I found it useful for building the installer under Linux in one step. Otherwise said, wine is not a requirement. Actually, groupvpn.nsi, official NSIS (configured with the plugins in whichever way you prefer) and ../build/acisp2p.x.yy.zip are all you need.
  • All plugins are coming from http://nsis.sourceforge.net/Category:Plugins. I preferred to bundle them because there's no easier and/or automated way to collect them. Some of them can be found in their MediaWiki, some are in the forum as attachments. Collecting them one by one is possible but not convenient. (I myself had no fun re-collecting them once after switching my OS). If you still prefer that way, here's the list of plugins I used:

http://nsis.sourceforge.net/NSIS_Simple_Firewall_Plugin
http://nsis.sourceforge.net/NSIS_Simple_Service_Plugin
http://nsis.sourceforge.net/TextReplace_plugin
http://nsis.sourceforge.net/XML_plug-in
http://nsis.sourceforge.net/ZipDLL_plug-in
http://nsis.sourceforge.net/NsDialogs_CreateIPaddress

As for license, according to http://nsis.sourceforge.net/License we can say:

All NSIS source code, plug-ins, documentation, examples, header files and graphics, with the exception of the compression modules and where otherwise noted, are licensed under the zlib/libpng license.

And, I don't see any other generated files as you mentioned.

scripts/groupvpn/nsis - the plugin files (some dlls and some nsh scripts)
scripts/groupvpn/arch - Arch Linux packaging scripts (nothing to do with NSIS/win32)
scripts/groupvpn/groupvpn.nsi - the thing we are talking about
scripts/groupvpn/Makefile - for convenience

Question: Do you want me to (try to) write Makefile sections to download those plugins on build?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants