forked from kworkflow/kworkflow
-
Notifications
You must be signed in to change notification settings - Fork 0
Kw manage contacts #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JGBSouza
wants to merge
11
commits into
davidbtadokoro:unstable
Choose a base branch
from
JGBSouza:kw_manage_contacts
base: unstable
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new function that is used to get the position of the first occurence of a char in the given string. This function will be useful in upcoming commits where we will have to check char precedence in a given string. Signed-off-by: JGBSouza <joaosouzaaa12@gmail.com>
The code didnt match it's own description as it doesnt check for the character `,` in the given string. In this sense, fix the function so this case will also be checked. Also, add more test cases to check for all the special characters. Signed-off-by: JGBSouza <joaosouzaaa12@gmail.com>
To support the new `kw manage-contacts` feature, we are adding initial files and creating database tables to store the necessary information. This includes SQL commands to create the tables `email-contact`, `email_group` & `email_contact_group` and the file src/manage-contacts with the initial versions of `parse_manage_contacts_options` and the `manage_contacts_main`. Signed-off-by: JGBSouza <joaosouzaaa12@gmail.com>
To support the new feature `kw manage-contacts`, it should be able to create a new group. In this sense, add a new functionality `create-group` that receives a group name and creates a group in the `email_group` database with the group id, name, creation-date. Signed-off-by: JGBSouza <joaosouzaaa12@gmail.com>
To support the new `kw manage-contacts` feature, we need a method for removing groups if the user decides to do so. To handle it, create a new functionality `kw manage-contacts group-remove` wich recieves a name of an existent group and remove it and it's informations from the database. Signed-off-by: JGBSouza <joaosouzaaa12@gmail.com>
To support the new feature `kw manage_contacts` we need a method to rename the groups after they are created. In this sense add the new functionality `--group-rename` wich recieves the old and the new name of a group and update the entry in the database. Signed-off-by: JGBSouza <joaosouzaaa12@gmail.com>
To support the new `kw manage_contacts` feature, we need a method to add contacts to groups. In this sense, add the new functionality `--group-add` that recieves a group and a list of names and emails of the contacts and add the contacts and the group association in the database. Signed-off-by: JGBSouza <joaosouzaaa12@gmail.com>
To support the new feature `kw manage_contacts`, it should be able to remove contacts fom the groups based on the contact email. In this sense, add the new functionality `group-remove-email` that recieves the group wich the contact is member and the contact email and remove it's association. Otherwise, if the contact has no groups after removing the conection, also remove the contact from the database. Signed-off-by: JGBSouza <joaosouzaaa12@gmail.com>
To support the new feature `kw manage-contacts`, it should be able to display the groups infos after they are created or the contacts infos from an specific group. In this sense, add the new functionality `--grops-show` wich can recieve an specific group infos and it's contacts or all the groups infos in case no parameter is passed. Signed-off-by: JGBSouza <joaosouzaaa12@gmail.com>
Added documentation outlining the usage of kw manager commands for creating, renaming, adding/removing contacts, and showing email groups. Each command is described with its respective options and arguments for clarity and ease of use. Signed-off-by: JGBSouza <joaosouzaaa12@gmail.com>
To support the new feature `kw manage_contacts`, it should be able to send patches specifing the contact groups that will receive the email or it's copy. In this sense, add the new options `to-groups` and `cc-groups` to enable the users to use the groups created with the `kw manage_contacts` Signed-off-by: JGBSouza <joaosouzaaa12@usp.br>
3a2b1a9 to
9f24b40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add basic solutions for kworkflow#657 and kworkflow#550.