added python3 versions of the clustering and sQTL preparing scripts#154
Merged
davidaknowles merged 1 commit intodavidaknowles:masterfrom Sep 29, 2020
Merged
added python3 versions of the clustering and sQTL preparing scripts#154davidaknowles merged 1 commit intodavidaknowles:masterfrom
davidaknowles merged 1 commit intodavidaknowles:masterfrom
Conversation
davidaknowles
approved these changes
Sep 29, 2020
Owner
davidaknowles
left a comment
davidaknowles
left a comment
There was a problem hiding this comment.
Nice, thanks @jackhump. We should really aim to just move everything to python3 at some point - not sure how much we should worry about backwards compatibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's high time we updated the core python scripts to python3. This work was initially begun by @mdshw5 in #85 . I took his ported code and fixed a few bugs.
Both scripts have been used extensively by me for the past 6 months so I'm confident that the porting was successful.
I suggest that we update the documentation to mention that the python3 versions are now available and then in a later release we can replace the old scripts with the new ones entirely.