Skip to content

Update leafcutter_cluster_regtools.py#146

Open
boxiangliu wants to merge 1 commit intodavidaknowles:masterfrom
boxiangliu:patch-2
Open

Update leafcutter_cluster_regtools.py#146
boxiangliu wants to merge 1 commit intodavidaknowles:masterfrom
boxiangliu:patch-2

Conversation

@boxiangliu
Copy link

Changed line 392: refine_cluster() -> if (count/float(totN) >= cutoff and count >= readcutoff): to if (count/float(totN) >= cutoff and totN >= readcutoff):

Changed line 392: `refine_cluster()` -> `if (count/float(totN) >= cutoff and count >= readcutoff):` to `if (count/float(totN) >= cutoff and totN >= readcutoff):`
@TimD1
Copy link

TimD1 commented Jan 7, 2025

Seconding this issue, @davidaknowles .

As is, leafcutter filters each junction if the per-junction read count is less than --minclureads instead of filtering each cluster if the total number of reads supporting all junctions in a cluster are less than --minclureads.

Based on the command-line help info, this is not the intended behavior.

-m MINCLUREADS, --minclureads=MINCLUREADS
                        minimum reads in a cluster (default 30 reads)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants