X11 Add support for video/screen scaling#9
Open
buserror wants to merge 4 commits intodavid-schmidt:mainfrom
Open
X11 Add support for video/screen scaling#9buserror wants to merge 4 commits intodavid-schmidt:mainfrom
buserror wants to merge 4 commits intodavid-schmidt:mainfrom
Conversation
GCC has pretty handy builtin for that sort of things, often reduces to a single opcode on the target processor Signed-off-by: Michel Pollet <buserror@gmail.com>
Allow Makefile to define BORDER_WIDTH Signed-off-by: Michel Pollet <buserror@gmail.com>
Use __attribute__((packed)) for gcc, so make sure these structures are byte aligned Signed-off-by: Michel Pollet <buserror@gmail.com>
This adds support for scaling the window of the emulator. On 4K screens, GSport window is really tiny and unreadable. This implements another stage to the rendering using the XRender extension with a scaling transform. This appears to work with or without shared memory Also, modifies the Makefile to easily switch scaling on or off -- technically if could be made configurable at runtime too, for the moment the constant is passed as a #define Signed-off-by: Michel Pollet <buserror@gmail.com>
Author
|
Anyone knows if this project has been forked into something that accepts PRs? it's been nearly 3 years now... |
Owner
|
Hey, good to hear from you again! This one somehow escaped my notice. I'd say "we still accept PRs," but I see what you mean here. :-) The upstream KEGS project is here, but Kent doesn't do GitHub, so contribution is a little more old-school: I'm maintaining a GitHub-based mirror of it to make creating patches easier: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a 4K screen, GSport window is /tiny/ -- this PR adds support for scaling, by adding support for rendering via the XRender extension using a scaling transform. It should be accelerated on pretty much any hardware these days, so has no real impact on performance.
Technically this makes the scaling configurable at runtime, but at the moment it is #defined as x2. I tried to minimize impact on existing code.
This PR also contains a few little fixes for modern GCC, for example there is a commit to use __builtin_bswap; it also force align the prodos.h structures, as that wouldn't work on 64 bits systems at least using gcc.