Upgrade sbt-typelevel and related configurations #461
Conversation
…sbt-typelevel setup.
build.sbt
Outdated
| ThisBuild / crossScalaVersions := Seq("2.12.17", "2.13.11", "3.3.0") | ||
| ThisBuild / scalaVersion := "3.3.0" |
There was a problem hiding this comment.
Let's update all of the Scala versions here :)
- Scala 3 -> 3.3.4
- This will require bumping Scala Native to the latest version in the 0.4.x line: 0.4.17
- Scala 2.13 -> 2.13.16
- Scala 2.12 -> 2.12.20
project/build.properties
Outdated
| @@ -1 +1 @@ | |||
| sbt.version=1.8.2 | |||
| sbt.version=1.10.7 | |||
There was a problem hiding this comment.
Oh let's also bump our sbt version all the way up to the latest: v1.10.10
samspills
left a comment
samspills
left a comment
There was a problem hiding this comment.
This is great work, thank you 🎉 🎉
|
I've also tagged @valencik for review, as he's a co-mentor on the project! |
valencik
left a comment
valencik
left a comment
There was a problem hiding this comment.
Nice work! Looks good to me, just some minor suggestions.
We could maybe add the big reformatting commit to a .git-blame-ignore-revs file so it doesn't show up in git blames. You can see an example of one here:
https://github.com/typelevel/cats/blob/main/.git-blame-ignore-revs
modules/caffeine/src/main/scala/io/chrisdavenport/mules/caffeine/CaffeineCache.scala
Outdated
Show resolved
Hide resolved
build.sbt
Outdated
|
|
||
| ThisBuild / crossScalaVersions := Seq("2.12.17", "2.13.8", "3.2.2") | ||
| ThisBuild / scalaVersion := "3.2.2" | ||
| ThisBuild / crossScalaVersions := Seq("2.12.20", "2.13.16", "3.3.4") |
There was a problem hiding this comment.
Scala 3.3.5 is out now and used elsewhere.
| ThisBuild / crossScalaVersions := Seq("2.12.20", "2.13.16", "3.3.4") | |
| ThisBuild / crossScalaVersions := Seq("2.12.20", "2.13.16", "3.3.5") |
There was a problem hiding this comment.
We can't update to Scala 3.3.5 because that would force us on to Scala Native 0.5.x and we can't make that bump until cats-effect moves forward there
There was a problem hiding this comment.
Andrew is right, I think we were just going about the upgrades in an unfortunate order previously. Using Scala Native 0.4.17 and Scala 3.3.5 will work as far as I can figure :)
build.sbt
Outdated
| ThisBuild / crossScalaVersions := Seq("2.12.17", "2.13.8", "3.2.2") | ||
| ThisBuild / scalaVersion := "3.2.2" | ||
| ThisBuild / crossScalaVersions := Seq("2.12.20", "2.13.16", "3.3.4") | ||
| ThisBuild / scalaVersion := "3.3.4" |
There was a problem hiding this comment.
| ThisBuild / scalaVersion := "3.3.4" | |
| ThisBuild / scalaVersion := "3.3.5" |
|
added big formatting commit to .git-blame-ignore-revs |
…ne/CaffeineCache.scala Co-authored-by: Andrew Valencik <valencik@users.noreply.github.com>
3 participants
Migrated build to sbt-typelevel
Updated Scala version to 3.3.0