fix: remove placeholder MCP servers from onboarding template#38
Open
caleb-love wants to merge 1 commit intodavekilleen:mainfrom
Open
fix: remove placeholder MCP servers from onboarding template#38caleb-love wants to merge 1 commit intodavekilleen:mainfrom
caleb-love wants to merge 1 commit intodavekilleen:mainfrom
Conversation
Placeholder integration servers (google-workspace, teams, todoist,
things3, trello, zoom, atlassian) ship in .mcp.json.example with
template credentials like {{GOOGLE_CLIENT_ID}}. These get copied into
the user's live .mcp.json during onboarding and load every session,
wasting ~30K-50K context tokens even though they can't authenticate.
Changes:
- Remove 7 placeholder entries from System/.mcp.json.example
- Add safety filter in setup_mcp_config() to strip any remaining
unresolved {{...}} placeholder patterns (defense-in-depth)
- Update /dex-update sync logic to skip placeholder entries
Setup skills (/todoist-setup, /gmail-setup, etc.) already handle
adding servers with real credentials when users configure them.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
dc61ac8 to
9b49904
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.mcp.json.examplewith template credentials like{{GOOGLE_CLIENT_ID}}.mcp.jsonduring onboarding and load every session, registering tool schemas into Claude's context even though they can't authenticateChanges
System/.mcp.json.example— Remove 7 placeholder integration entries (55 lines). Only the 11 core servers that work out of the box remain.core/mcp/onboarding_server.py— Add a safety filter insetup_mcp_config()that strips any server entries with unresolved{{...}}placeholder patterns in their env values. Defense-in-depth so future template additions with placeholders won't leak into live configs..claude/skills/dex-update/SKILL.md— Update the MCP sync logic to skip entries with unresolved placeholder patterns, preventing the update flow from re-adding placeholder servers.Why this is safe
/todoist-setup,/gmail-setup,/atlassian-setup, etc.) already handle adding servers with real credentials when users configure integrations — this just stops pre-loading unused ones{{...}}patterns, so any user who has already replaced placeholders with real credentials is unaffected{{VAULT_PATH}}is replaced before the filter runs, so core servers are never filtered outTest plan
setup_mcp_config()on a fresh vault — verify output contains only 11 core servers{{...}}patterns in generated.mcp.json(except none should remain)/todoist-setup) — verify it still adds the server entry correctly/dex-update— verify placeholder entries are not re-added