Skip to content

Fix remaining audit findings#16

Merged
davegomez merged 4 commits intomainfrom
fix/audit-remaining-findings
Feb 1, 2026
Merged

Fix remaining audit findings#16
davegomez merged 4 commits intomainfrom
fix/audit-remaining-findings

Conversation

@davegomez
Copy link
Owner

An audit against the Fizzy API docs found CardSchema silently dropped the plain text description field during Zod parsing, fizzy_search exposed only 6 of the 12 available query filters, and the boards tool had no pagination continuation test coverage.

CardSchema now accepts the optional description field alongside description_html. Six missing search filters — creator_ids, closer_ids, card_ids, assignment_status, creation, closure — thread through schema, client, and tool layers. A cursor-based pagination test verifies multi-page board fetches end-to-end. README updated to reflect the expanded parameter surface.

480 tests pass, lint and typecheck clean.

API returns plain text description alongside description_html.
Schema was silently dropping it during Zod parsing.
Verifies cursor-based pagination: page 1 returns next_cursor with
has_more=true, page 2 via cursor returns final results with has_more=false.
Add creator_ids, closer_ids, card_ids, assignment_status, creation,
and closure filters across schema, client, and tool layers.
@davegomez davegomez self-assigned this Feb 1, 2026
@greptile-apps
Copy link

greptile-apps bot commented Feb 1, 2026

Greptile Overview

Greptile Summary

Fixed three audit findings against the Fizzy API: added missing description field to CardSchema, exposed 6 previously unavailable search filters (creator_ids, closer_ids, card_ids, assignment_status, creation, closure), and added cursor-based pagination test for boards.

  • Added optional description field alongside existing description_html in CardSchema (src/schemas/cards.ts:48)
  • Extended CardFiltersSchema with 6 new filter fields matching Fizzy API capabilities
  • Threaded new filters through client query parameter building (src/client/fizzy.ts:450-466)
  • Updated fizzy_search tool parameter schema and execute function to accept new filters
  • Added comprehensive test coverage: schema validation tests for all new filters, parameter passing tests, and multi-page board pagination test
  • Updated README to document all 12 search parameters with date range value reference

All changes follow existing patterns - array filters use append() for query params, single-value filters use set(), optional fields marked properly with Zod. Test assertions verify correct parameter serialization.

Confidence Score: 5/5

  • Safe to merge - audit fixes with comprehensive test coverage
  • All changes are additive (no breaking changes), follow established codebase patterns, have thorough test coverage including edge cases, and the PR reports 480 passing tests with clean lint/typecheck
  • No files require special attention

@davegomez davegomez merged commit 7f895c8 into main Feb 1, 2026
2 checks passed
@davegomez davegomez deleted the fix/audit-remaining-findings branch February 1, 2026 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant