Fix step creation mock to return 201+Location#15
Merged
Conversation
Greptile OverviewGreptile SummaryThis PR updates the MSW step-creation mock to better match the real Fizzy API by returning Confidence Score: 4/5
|
The tool only exposed create. Add action param (create/list/update/delete) with backward-compatible default. Validate comment_id for update/delete, body for create/update.
Base POST steps mock returned 200+JSON body instead of 201+Location header with empty body like the real API. This meant the client's 201+Location follow logic was never exercised by the base handler. Add GET /steps/:stepId handler and lastCreatedStep storage to support the follow. Add test for creating a step with completed: true. Closes #24
ecbc089 to
780ba61
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The base POST steps mock handler returned 200 with a JSON body, but
the real Fizzy API returns 201 with a
Locationheader and empty body.This meant the client's 201+Location follow logic in
request()wasnever exercised by the default mock — only by per-test overrides.
Now the base handler stores the created step via
lastCreatedStepandreturns
201 + Location, matching thelastCreatedCardpattern alreadyused for card creation. A corresponding GET
/steps/:stepIdhandlerserves the stored step on follow. Also adds a missing test for creating
a step with
completed: true.Closes #24