Skip to content

Fix search tag fixtures and add missing filters#12

Merged
davegomez merged 3 commits intomainfrom
fix/fizzy-search-tag-fixtures-missing-filters
Feb 1, 2026
Merged

Fix search tag fixtures and add missing filters#12
davegomez merged 3 commits intomainfrom
fix/fizzy-search-tag-fixtures-missing-filters

Conversation

@davegomez
Copy link
Owner

The mockCard test fixture used object-shaped tags ({id, title, color}) while the API returns plain strings (["bug"]). This mismatch meant tests passed but didn't reflect real API behavior. Fixed the fixture and its assertions.

CardSchema was missing several optional fields the live API returns — image_url, golden, last_active_at, embedded board/column/creator refs, comments_url, and reactions_url. Added them all as optional to avoid breaking existing consumers.

fizzy_search now supports sorted_by (newest/oldest/recently_active) and terms (free-text search) filters, wired through schema → tool params → client query construction. Users can sort results and search by keywords without dropping to raw API calls.

Tags are plain strings, not objects. The fixture used object format
while the schema correctly expected strings.
Add optional fields returned by the live API: image_url, golden,
last_active_at, board/column/creator refs, comments_url, reactions_url.
Enable sorting results by newest/oldest/recently_active and filtering
by free-text search terms via the fizzy_search tool.
@greptile-apps
Copy link

greptile-apps bot commented Feb 1, 2026

Greptile Overview

Greptile Summary

Aligned test fixtures with actual API behavior and added new search capabilities. The mockCard fixture previously used object-shaped tags but the API returns plain strings, causing tests to pass despite the mismatch. Expanded CardSchema with optional fields returned by the live API (image_url, golden, last_active_at, embedded refs, URL fields). Added sorted_by and terms filters to enable sorting and free-text search without raw API calls.

  • Fixed tag fixture format from objects to strings in src/tools/cards.test.ts:36
  • Added 8 optional fields to CardSchema including embedded board/column/creator references
  • Implemented sorted_by filter (newest/oldest/recently_active) with full test coverage
  • Implemented terms array filter for keyword search with test verification
  • All changes maintain backward compatibility through optional fields

Confidence Score: 5/5

  • Safe to merge - well-tested feature additions with backward compatibility
  • All changes are additive (optional schema fields, new filters) with comprehensive test coverage. Tag fixture fix ensures tests reflect actual API behavior. No breaking changes or risky modifications.
  • No files require special attention

@davegomez davegomez merged commit 21a5506 into main Feb 1, 2026
2 checks passed
@davegomez davegomez deleted the fix/fizzy-search-tag-fixtures-missing-filters branch February 1, 2026 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant