Skip to content

Conversation

@jlaunay
Copy link

@jlaunay jlaunay commented Dec 17, 2025

Summary

This PR adds full support for three types of EPUB footnotes: inline <aside> elements, paragraph notes <p class="note">, and external footnote references. Users can now view footnotes directly from any page and navigate to their content seamlessly.

What changes are included?

  • Footnote Detection & Collection: Two-pass parsing system that first collects inline footnotes and paragraph notes, then processes the main content
  • Footnote Navigation: Navigate to footnote content and return to your original reading position
  • Footnote UI: New menu system with dedicated footnote viewer screen showing all notes for the current page
  • Virtual Spine Items: Generate HTML files on-the-fly for inline footnotes, added to the EPUB spine as virtual pages

@daveallie
Copy link
Owner

Hey @jlaunay, I know it's going to be a bit of a refactor, but I'd like to get #44 in before screens get a too out of control, apologies if the merge/rebase is a pain

@jlaunay
Copy link
Author

jlaunay commented Dec 17, 2025

@daveallie I tried refactoring it, let me know if it seemed okay to you.

Edit: Since the refactor, I have an issue with inline aside footnotes. I'll need to compare the code that was working with the current one to find the problem with a clear head.

@daveallie
Copy link
Owner

Hi @jlaunay, thanks for submitting this, I'm still getting around to reviewing it, don't worry, I haven't forgotten about it!

@jlaunay
Copy link
Author

jlaunay commented Dec 19, 2025

Hello, the original version before the refactor (here) worked very well, but given the number of changes in the master branch (screen to activities etc.) and the merges that were done quickly, I cannot manage to refactor it properly.

If someone can help, I would really appreciate it. I lack the skills and the time to get it done :/

@daveallie
Copy link
Owner

Apologies, things have been moving pretty quickly, I am happy to help jump in here and help out. I should have some time in the next two days to sit down and parse through this PR to get it back up to speed.

@daveallie daveallie added enhancement New feature or request reader Related to the core reader experience labels Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request reader Related to the core reader experience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants