-
-
Notifications
You must be signed in to change notification settings - Fork 32
Feature/footnotes #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@daveallie I tried refactoring it, let me know if it seemed okay to you. Edit: Since the refactor, I have an issue with inline aside footnotes. I'll need to compare the code that was working with the current one to find the problem with a clear head. |
This reverts commit ad7e9bd.
|
Hi @jlaunay, thanks for submitting this, I'm still getting around to reviewing it, don't worry, I haven't forgotten about it! |
|
Hello, the original version before the refactor (here) worked very well, but given the number of changes in the master branch (screen to activities etc.) and the merges that were done quickly, I cannot manage to refactor it properly. If someone can help, I would really appreciate it. I lack the skills and the time to get it done :/ |
|
Apologies, things have been moving pretty quickly, I am happy to help jump in here and help out. I should have some time in the next two days to sit down and parse through this PR to get it back up to speed. |
Summary
This PR adds full support for three types of EPUB footnotes: inline
<aside>elements, paragraph notes<p class="note">, and external footnote references. Users can now view footnotes directly from any page and navigate to their content seamlessly.What changes are included?