fix: eliminate e-ink ghosting on menu navigation and beautify UI #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add configurable auto-sleep timeout in Settings with options: - 1 minute - 5 minutes - 10 minutes (default) - 15 minutes - 30 minutes Changes: - Add SLEEP_TIMEOUT enum and sleepTimeout field to CrossPointSettings - Add getSleepTimeoutMs() helper method - Add sleepTimeout to settings serialization - Add 'Time to Sleep' option in SettingsActivity - Replace hardcoded AUTO_SLEEP_TIMEOUT_MS with SETTINGS.getSleepTimeoutMs()
Problem: E-ink display showed significant ghosting when navigating between menu screens. The HALF_REFRESH LUT was not applied consistently when entering or re-entering menu activities. Root Cause: 1. HALF_REFRESH only triggered on initial activity creation, not re-entry 2. Race conditions between main loop and display task 3. Empty directory early return bypassed HALF_REFRESH logic Solution: - FileSelectionActivity: Track lastRenderedPath to detect directory changes Use HALF_REFRESH when path differs. Mutex-protect updateRequired writes. - Other menus: Reset isFirstRender in onEnter() for HALF_REFRESH on entry UI improvements: - FileSelectionActivity: Header shows Browse/path, improved empty state - XtcReaderChapterSelectionActivity: Layout consistency, text truncation - EpubReaderChapterSelectionActivity: Text truncation and button hints
- Removed trailing slashes from directory names - Added '>' prefix to directories - Indented file names for better visual alignment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
E-ink display showed significant ghosting when navigating between menu screens (file browser, settings, home, chapter selection). The custom LUT that clears ghosting (HALF_REFRESH) was not being applied consistently when entering or re-entering menu activities.
Root Cause
Solution
FileSelectionActivity (most complex case)
lastRenderedPathstring comparison to detect actual directory changes race-free.HALF_REFRESHonly when the path differs (directory changed), not on navigation within the same directory.updateRequiredwrites with a mutex to ensure synchronization between input and display tasks.Other Menu Activities (Home, Settings, EpubChapterSelection, XtcChapterSelection)
isFirstRenderflag reset inonEnter()method to ensureHALF_REFRESHis applied every time the activity is entered.UI Improvements
> FolderName(removed trailing slashes).Testing