Skip to content

Replacing @datum-ui/buttons with datum-cloud/datum-ui::Button#331

Open
kevwilliams wants to merge 16 commits intomainfrom
feat/button-swap
Open

Replacing @datum-ui/buttons with datum-cloud/datum-ui::Button#331
kevwilliams wants to merge 16 commits intomainfrom
feat/button-swap

Conversation

@kevwilliams
Copy link
Contributor

@kevwilliams kevwilliams commented Feb 18, 2026

Replacing all uses of @datum-ui/button with the design system, importing @datum-cloud/datum-ui button.

@gaghan430
Copy link
Contributor

Hey guys, are you seeing the same error when trying to run this, or is it just not ready to be reviewed yet?
@yahyafakhroji @mattdjenkinson
image

@yahyafakhroji
Copy link

@gaghan430 yes, i experienced the same thing
Screenshot 2026-02-19 at 14 35 00

@kevwilliams
Copy link
Contributor Author

I did not see this but I will check my working copy and see if there's something I am missing in the Pr thanks for checking!

@kevwilliams
Copy link
Contributor Author

@yahyafakhroji @gaghan430 This should be ready for another look! Thank you!

@gaghan430
Copy link
Contributor

gaghan430 commented Feb 20, 2026

nice... but I think some styles are broken

your branch vs staging

Screen.Recording.2026-02-20.at.09.37.44.mov

@kevwilliams
Copy link
Contributor Author

Ok this is once again ready for review, I made some decisions on the colors and after talking with Matt used the cloud-portal as our source of truth going forward there. This PR also brings the portals colors and styles together which will eventually all be the design system.

image

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the use of datum-cloud, can it be simplified? For example, only need to import 1 style file (In this example, we need to put 4 line code of requirements from datum-cloud)

or should it not even be necessary? because all style settings should already be built into datum-cloud

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to simplify this a little bit from the datum-ui side by making a theme.css file there that combines these things so we can just import one line here. We need to merge it on the datum-ui side first, but you can put the file in place in your local copy in the meantime to test if you want.

https://github.com/datum-cloud/olli/pull/5/changes#diff-c5f1350d3843073c97275775e2ef7c721bb0c9dc5e30608028b37de882b36ff1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants