Replacing @datum-ui/buttons with datum-cloud/datum-ui::Button#331
Replacing @datum-ui/buttons with datum-cloud/datum-ui::Button#331kevwilliams wants to merge 16 commits intomainfrom
Conversation
|
Hey guys, are you seeing the same error when trying to run this, or is it just not ready to be reviewed yet? |
|
@gaghan430 yes, i experienced the same thing |
|
I did not see this but I will check my working copy and see if there's something I am missing in the Pr thanks for checking! |
|
@yahyafakhroji @gaghan430 This should be ready for another look! Thank you! |
|
nice... but I think some styles are broken your branch vs staging Screen.Recording.2026-02-20.at.09.37.44.mov |
There was a problem hiding this comment.
For the use of datum-cloud, can it be simplified? For example, only need to import 1 style file (In this example, we need to put 4 line code of requirements from datum-cloud)
or should it not even be necessary? because all style settings should already be built into datum-cloud
There was a problem hiding this comment.
I was able to simplify this a little bit from the datum-ui side by making a theme.css file there that combines these things so we can just import one line here. We need to merge it on the datum-ui side first, but you can put the file in place in your local copy in the meantime to test if you want.
4d87eae to
b4cfa09
Compare



Replacing all uses of @datum-ui/button with the design system, importing @datum-cloud/datum-ui button.