fix: resolve gateway annotation phantom-blocking and httpproxy reconciliation storm#120
Merged
zachsmith1 merged 1 commit intomainfrom Feb 27, 2026
Merged
Conversation
…iliation storm Made-with: Cursor
scotwells
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three fixes for the gateway and httpproxy controllers:
Only set cert-manager annotations for claimed listeners — unclaimed custom hostnames with TLS options were phantom-blocking shared TLS by adding cert-manager annotations to the downstream gateway even though the listener itself was skipped. Also adds syncCertManagerAnnotations to clean up stale annotations in the update path.
Return early on downstream gateway Get errors — a non-NotFound error set result.Err but continued execution, falling into the create path and bypassing the update path where annotation cleanup occurs.
Preserve hostname status lastTransitionTime across reconciles — the httpproxy controller rebuilt HostnameStatus conditions from scratch every reconcile, setting lastTransitionTime to time.Now(). This caused a spurious status diff on every loop, driving an infinite reconciliation storm (~1000 updates per 10 minutes per project).
Ref: datum-cloud/enhancements#622