Skip to content

fix(notes): resolve subject API version dynamically instead of hardcoding#508

Merged
scotwells merged 1 commit intomainfrom
bugfix/notes-webhook-use-restmapper-for-subject-gvk
Feb 27, 2026
Merged

fix(notes): resolve subject API version dynamically instead of hardcoding#508
scotwells merged 1 commit intomainfrom
bugfix/notes-webhook-use-restmapper-for-subject-gvk

Conversation

@scotwells
Copy link
Contributor

Summary

  • Fixes error when creating notes on Domain resources: "no matches for kind Domain in version networking.datumapis.com/v1alpha1"
  • The webhook was assuming all resources use v1alpha1, but Domain uses v1alpha
  • Now the webhook automatically discovers the correct API version

Test plan

  • Unit tests passing
  • Create a note on a Domain resource and verify it succeeds

🤖 Generated with Claude Code

…ding

Notes webhook was failing when creating notes on Domain resources with
error "no matches for kind Domain in version networking.datumapis.com/v1alpha1"
because the webhook assumed all resources use v1alpha1, but Domain uses v1alpha.

Now the webhook discovers the correct API version automatically using the
cluster's REST mapper.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@joggrbot
Copy link
Contributor

joggrbot bot commented Feb 27, 2026

📝 Documentation Analysis

All docs are up to date! 🎉


✅ Latest commit analyzed: 4dd68fa | Powered by Joggr

@scotwells scotwells merged commit 3c4e4ed into main Feb 27, 2026
6 checks passed
@scotwells scotwells deleted the bugfix/notes-webhook-use-restmapper-for-subject-gvk branch February 27, 2026 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants