Skip to content

Security and trust promise#61

Closed
thomasdaly5 wants to merge 7 commits intomainfrom
security-and-trust-promise
Closed

Security and trust promise#61
thomasdaly5 wants to merge 7 commits intomainfrom
security-and-trust-promise

Conversation

@thomasdaly5
Copy link

@thomasdaly5 thomasdaly5 commented Mar 25, 2025

Initial draft our our security and trust promise.

joshlreese
joshlreese previously approved these changes Mar 25, 2025
View reviewed changes
Copy link
Contributor

@joshlreese joshlreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I came across a handful of typos while reviewing and recommended some fixes.

Only remaining comment is regarding line length, which I mentioned in #55 (review) as well.

@github-project-automation github-project-automation bot moved this from Todo to Done in Datum Launch Release Mar 25, 2025
mksinghtx
mksinghtx previously approved these changes Mar 26, 2025
View reviewed changes
Copy link
Contributor

@mksinghtx mksinghtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per our discussion on slack I have added attachments to the issues and we can take a look and reconcile and review at next iteration.

@thomasdaly5 @joshlreese
Update enhancements/platform/security-and-trust-promise.md
a4d1cc4 
Co-authored-by: Joshua Reese <joshlreese@gmail.com>
Signed-off-by: Tom Daly <tjd@q7.io>
@thomasdaly5 thomasdaly5 dismissed stale reviews from mksinghtx and joshlreese via a4d1cc4 March 26, 2025 22:22
thomasdaly5 and others added 2 commits March 26, 2025 18:22
@thomasdaly5 @joshlreese
Update enhancements/platform/security-and-trust-promise.md
d0986fc 
Co-authored-by: Joshua Reese <joshlreese@gmail.com>
Signed-off-by: Tom Daly <tjd@q7.io>
Rewrap to 80 columns.
ba3c995
@thomasdaly5
Copy link
Author

thomasdaly5 commented Mar 26, 2025

Looks good! I came across a handful of typos while reviewing and recommended some fixes.

Only remaining comment is regarding line length, which I mentioned in #55 (review) as well.

Rewrapped to 80 columns as requested.

@thomasdaly5 thomasdaly5 requested a review from joshlreese March 26, 2025 22:26
@scotwells scotwells moved this from Done to Todo in Datum Launch Release Jun 20, 2025
@scotwells scotwells moved this from Todo to In Progress in Datum Launch Release Jun 20, 2025
ecv
ecv approved these changes Jan 30, 2026
View reviewed changes
Copy link
Contributor

@ecv ecv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this landing actually. @datum-cloud/engineering RFC

@scotwells
Copy link
Contributor

scotwells commented Jan 30, 2026

This feels like something that should go in our handbook on datum.net. Not something that should go in our enhancements repo. Thoughts @drewr / @jacobsmith928 / @mksinghtx ?

@jacobsmith928 jacobsmith928 removed the request for review from joshlreese February 3, 2026 15:50
jacobsmith928
jacobsmith928 approved these changes Feb 3, 2026
View reviewed changes
Copy link
Member

@jacobsmith928 jacobsmith928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to go, time to make it reality @ecv !

@jacobsmith928
Copy link
Member

jacobsmith928 commented Feb 10, 2026

@scotwells yeah we have our policies here:
https://www.datum.net/handbook/policy/

@scotwells
Copy link
Contributor

scotwells commented Feb 10, 2026

@jacobsmith928 so you agree we can just close this and let the content live in the handbook?

@jacobsmith928
Copy link
Member

jacobsmith928 commented Feb 10, 2026 via email

@scotwells scotwells closed this Feb 12, 2026
@scotwells scotwells deleted the security-and-trust-promise branch February 12, 2026 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ecv ecv ecv approved these changes

@jacobsmith928 jacobsmith928 jacobsmith928 approved these changes

@mksinghtx mksinghtx mksinghtx approved these changes

@scotwells scotwells Awaiting requested review from scotwells

+1 more reviewer

@joshlreese joshlreese joshlreese left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

No open projects
Datum Launch Release
Status: In Progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@thomasdaly5 @scotwells @jacobsmith928 @joshlreese @ecv @mksinghtx