Open
Conversation
This was referenced Jan 19, 2026
Contributor
Author
|
@joshlreese please review when you have a second |
zachsmith1
force-pushed
the
feat/connector-envoy
branch
from
6093367 to
b1557e6
Compare
This was referenced Jan 19, 2026
feat: Add connector EnvoyPatchPolicy for HTTPProxy backends
datum-cloud/network-services-operator#93
Merged
Frando
reviewed
Jan 20, 2026
Frando
reviewed
Jan 20, 2026
Frando
left a comment
Frando
left a comment
There was a problem hiding this comment.
A couple of comments inline. On initial read, I don't see the doc describing the step how your control plane actually configures envoy (or how envoy fetches out to the control plane) so that envoy can map an incoming request's domain name to a connector + advertisment so that it can inject the correct headers when forwarding to the iroh sidecar.
On the details of the different ways to configure envoy with internal listeners for forwarding I can't comment much due to lack of experience with deploying envoy.
enhancements/networking/connectors/connector-envoy-design/README.md
Outdated
Show resolved
Hide resolved
enhancements/networking/connectors/connector-envoy-design/README.md
Outdated
Show resolved
Hide resolved
enhancements/networking/connectors/connector-envoy-design/README.md
Outdated
Show resolved
Hide resolved
enhancements/networking/connectors/connector-envoy-design/README.md
Outdated
Show resolved
Hide resolved
zachsmith1
force-pushed
the
feat/connector-envoy
branch
from
7d81e88 to
4109ee7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new connector/Envoy design doc for datum-connect/datum-desktop, detailing the end-to-end tunnel flow, sidecar metadata contract, and NSO programming responsibilities. It documents three Envoy Gateway implementation options with diagrams and validation notes, and clarifies MVP scope as CONNECT-TCP with a path to CONNECT-UDP. Open questions include which Envoy Gateway option to standardize on and whether to define an initial ConnectorClass (its intention and how it should work).