Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new Kubernetes Custom Resource Definition (CRD) for managing DNS TSIG keys (
TSIGKey) within the operator. This enables users to declaratively manage TSIG keys for DNS zone transfers and updates, supporting both controller-managed and user-supplied secrets. The PR also updates documentation, IAM roles, and sample manifests to support the new resource.Key changes:
TSIGKey CRD Implementation
TSIGKeyCRD (api/v1alpha1/tsigkey_types.go), including its spec, status, supported algorithms, validation rules, and deepcopy methods. This resource models DNS TSIG keys and supports referencing DNS zones and secrets, as well as controller-generated secrets.config/crd/bases/dns.networking.miloapis.com_tsigkeys.yaml) and includes it in the CRD kustomization (config/crd/kustomization.yaml).Ref: datum-cloud/enhancements#538