fix deprecation error on PHP 8.4 #17
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implicitly marking parameter $arguments as nullable is deprecated, the explicit nullable type must be used instead
tchalvak
reviewed
Feb 8, 2025
Author
There was a problem hiding this comment.
IIRC doing how I did permits to keep compatibility with PHP 5.6 & 7.0 (the syntax you suggest is valid since 7.1 only)
|
@smortensen could we get this merged? I think bumping the minimum to PHP 7.1 and using |
|
I contacted the original developer of this, and he doesn't have access to merge any pull requests. So my company has forked this and plans to maintain it going forward. You can use it at https://github.com/hcs-llc/php-json-rpc-http |
Author
|
Thanks. Do you also plan to release to packagist.org ? What's the authors point of view on that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implicitly marking parameter $arguments as nullable is deprecated, the explicit nullable type must be used instead