[pull] develop from Orcpub:develop#82
Merged
pull[bot] merged 8 commits intodatdamnzotz:developfrom Feb 20, 2026
Merged
Conversation
- Rename :if to :missing-else-branch (correct clj-kondo linter name) - Add :clojure-lsp/unused-public-var :exclude for 5 live vars that LSP can't trace (cross-file macro refs, test-only callers) - Add :exclude-when-defined-by for re-frame reg-event-db, reg-event-fx, reg-sub, reg-sub-raw (keyword dispatch is invisible to LSP)
#_ discard 43 dead vars: - common.cljc (4): ptime, hours-per-day, rounds-to-hours, rounds-to-minutes - character.cljc (6): add-namespaces + 2 cascade helpers, base-climbing-speed, saving-throw-advantages, max-armor-class - classes.cljc (4): blessings-of-knowledge-skill, spell-level-to-cleric-level, spell-in-spells-known?, pact-weapon-option - options.cljc (15): deprecated ua/scag refs (skill-or-expertise-selection, subclass-plugin, subclass-cantrip-selection, druid-cantrip-selection, eldritch-invocation-option, deep-gnome-option-cfg, subrace-prereq), #_ template refs (add-sources, artisans-tools-choice-cfg), zero-caller defs (levels, key-to-name, any-language-selection, charge-summary, defensive-duelist-summary, ability-modifiers, subclass-level-option) - template.cljc (14): ability roller UI (6 fns + score-costs + point-buy-points), amazon frames (3), content-list, custom-race-builder; #_ subscribe/dispatch refers (no live callers remain) Redundant expression fixes: - classes.cljc: remove nested (str (str ...)) - options.cljc: flatten (and (and ...)) in dual-wield checks, remove duplicate source destructuring param
#_ discard 49 dead vars: - views.cljs (25): style defs (header-tab-style, desktop-menu-item-style, search-icon-style, transparent-search-input-style, row-style, light-row-style, list-style, thumbnail-style, summary-style, option-pack-styles, invalid-styling), duplicate constants (rounds-per-minute, minutes-per-hour, hours-per-day), superseded components (srd-link, realize-char, svg-icon-section, compare-spell, equipment-section, default-image, select-builder-field, text-field, subrace-damage-resistance, selection-selector, no-https-images) - events.cljs (22): dead defs (max-iterations, dnd-5e-characters-path, validate-registration, set-active-tabs, remove-subtypes), 17 never-dispatched reg-event-db/fx handlers (toggle-public, load-characters, hide-warning, open-orcacle, set-builder-item, set-spell-list, set-feature-prop, toggle-feat-selection, toggle-*-value-prop, toggle-*-map-prop, etc.); remove unused tab-path refer - db.cljs (1): musical-instrument-choice-cfg (duplicate of classes.cljc) - subs.cljs (1): ::char5e/summary reg-sub (never subscribed to) Redundant expression fixes: - views.cljs: remove (str ...) wrapping bare strings - character_builder.cljs: remove (str "CLICK HERE...") on 4 string literals - events.cljs: remove (str "all-content.orcbrew") on 2 string literals
Merge the top-level :clojure-lsp/unused-public-var into the :linters section where clj-kondo actually reads it. Add missing settings from the lint-missing-else branch: :output exclude-files, garden.selectors unresolved-var, read-string exclude, folder-test/with-conn lint-as, and :missing-else-branch :warning.
Removed broken with-conn lint-as, added orcpub.errors unresolved-var exclude, added spell_subs cross-file refs to unused-public-var exclude.
The def was incorrectly marked as dead code, but the legal footer in main-page still references it. Remove the #_ reader discard and the stale "dead" comment.
lint: dead code cleanup + redundant expression fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )