Skip to content

Remove compliance policies #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eccles merged 1 commit into from
Mar 28, 2025
Merged

Remove compliance policies #280

eccles merged 1 commit into from
Mar 28, 2025

Conversation

@eccles
Copy link
Contributor

@eccles eccles commented Mar 27, 2025 •
edited
Loading

Deleted all compliance policies endpoints and tests.
Removed some argument types in the runner as this uses a heterogeneous
dict and it was too difficult to resolve this issue with the pyright
checker.

Removal of the compliance policies exposed some missing runner tests and these
had to be rewritten to obtain 100% coverage.

Add dependabot.yml

Test results

Functests

paul@turing:~/git/datatrails-python (dev/paul/10628-remove-compliance-policies)$ task functests
task: [about] ./scripts/builder.sh ./scripts/version.sh
task: [functests] ./scripts/builder.sh ./scripts/functests.sh
Python 3.9.21
test_access_policies_share_asset_with_different_attributes (functests.execaccess_policies.TestAccessPoliciesShare) ... skipped 'cannot run test as DATATRAILS_AUTHTOKEN_FILENAME_2 is not set'
test_access_policies_share_assets_symmetrically (functests.execaccess_policies.TestAccessPoliciesShare) ... skipped 'cannot run test as DATATRAILS_AUTHTOKEN_FILENAME_2 is not set'
test_access_policies_create (functests.execaccess_policies.TestAccessPoliciesSimple) ... ok
test_access_policies_delete (functests.execaccess_policies.TestAccessPoliciesSimple) ... ok
test_access_policies_list (functests.execaccess_policies.TestAccessPoliciesSimple) ... ok
test_access_policies_update (functests.execaccess_policies.TestAccessPoliciesSimple) ... ok
test_appidp_token (functests.execapplications.TestApplications) ... ok
test_appidp_token_404 (functests.execapplications.TestApplications) ... ok
test_applications_create (functests.execapplications.TestApplications) ... ok
test_applications_delete (functests.execapplications.TestApplications) ... ok
test_applications_list (functests.execapplications.TestApplications) ... ok
test_applications_regenerate (functests.execapplications.TestApplications) ... ok
test_applications_update (functests.execapplications.TestApplications) ... ok
test_archivist_token (functests.execapplications.TestApplications) ... skipped 'cannot run test as DATATRAILS_REFRESH_TOKEN is not set'
test_asset_create (functests.execassets.TestAssetCreate) ... ok
test_asset_create_event (functests.execassets.TestAssetCreate) ... ok
test_asset_create_merkle_log (functests.execassets.TestAssetCreate) ... ok
test_asset_create_with_fixtures (functests.execassets.TestAssetCreate) ... ok
test_asset_create_if_not_exists_with_bad_attachment (functests.execassets.TestAssetCreateIfNotExists) ... ok
test_asset_create_if_not_exists_with_bad_attachment_assetattachment (functests.execassets.TestAssetCreateIfNotExists) ... ok
test_attachment_info (functests.execattachments.TestAttachmentsCreate) ... skipped 'cannot run test as DATATRAILS_BLOB_IDENTITY is not set'
test_attachment_upload_and_download (functests.execattachments.TestAttachmentsCreate) ... ok
test_attachment_upload_and_download_allow_insecure (functests.execattachments.TestAttachmentsCreate) ... ok
test_attachment_upload_and_download_docx (functests.execattachments.TestAttachmentsCreate) ... ok
test_attachment_upload_and_download_strict (functests.execattachments.TestAttachmentsCreate) ... ok
test_attachment_malware_scan1 (functests.execattachments.TestAttachmentstMalware) ... ok
test_attachment_malware_scan2 (functests.execattachments.TestAttachmentstMalware) ... ok
test_attachment_malware_scan3 (functests.execattachments.TestAttachmentstMalware) ... ok
test_attachment_malware_scan4 (functests.execattachments.TestAttachmentstMalware) ... ok
test_01_create_artist_albuminfo (functests.execnotebooks.TestNotebooks) ... ok
test_02_find_artist_create_coverart (functests.execnotebooks.TestNotebooks) ... ok
test_03_find_artist_addtl_albuminfo (functests.execnotebooks.TestNotebooks) ... ok
test_create_event_with_verified_domain (functests.execnotebooks.TestNotebooks) ... ok
test_share_album_release_recordlabel (functests.execnotebooks.TestNotebooks) ... skipped 'Requires root access credentials -- see #7742'
test_share_album_release_user (functests.execnotebooks.TestNotebooks) ... skipped 'Requires root access credentials -- see #7742'
test_share_artist_asset_recordlabel (functests.execnotebooks.TestNotebooks) ... skipped 'Requires root access credentials -- see #7742'
test_share_artist_asset_user (functests.execnotebooks.TestNotebooks) ... skipped 'Requires root access credentials - see #7742'
test_asset_create_if_not_exists_with_bad_attachment_assetattachment (functests.execpublicassets.TestPublicAssetCreate) ... ok
test_public_asset_create (functests.execpublicassets.TestPublicAssetCreate) ... ok
test_public_asset_create_event (functests.execpublicassets.TestPublicAssetCreate) ... ok
test_runner_door_entry (functests.execrunner.TestRunner) ... ok
test_runner_estate_info (functests.execrunner.TestRunner) ... ok
test_runner_subjects (functests.execrunner.TestRunner) ... ok
test_runner_synsation (functests.execrunner.TestRunner) ... ok
test_runner_wipp (functests.execrunner.TestRunner) ... ok
test_subjects_count (functests.execsubjects.TestSubjects) ... ok
test_subjects_create (functests.execsubjects.TestSubjects) ... ok
test_subjects_create_b64 (functests.execsubjects.TestSubjects) ... ok
test_subjects_delete (functests.execsubjects.TestSubjects) ... ok
test_subjects_list (functests.execsubjects.TestSubjects) ... ok
test_subjects_update (functests.execsubjects.TestSubjects) ... ok

----------------------------------------------------------------------
Ran 51 tests in 81.845s

OK (skipped=8)

Pipeline functests

paul@turing:~/git/datatrails-python (dev/paul/10628-remove-compliance-policies)$ task pipeline-functests
task: [about] ./scripts/builder.sh ./scripts/version.sh
task: [pipeline-functests] ./scripts/builder.sh ./scripts/pipeline_functests.sh

Running tests...
----------------------------------------------------------------------
  test_access_policies_share_asset_with_different_attributes (functests.execaccess_policies.TestAccessPoliciesShare) ... skip (0.002s)
  test_access_policies_share_assets_symmetrically (functests.execaccess_policies.TestAccessPoliciesShare) ... skip (0.002s)
  test_access_policies_create (functests.execaccess_policies.TestAccessPoliciesSimple) ... ok (0.231s)
  test_access_policies_delete (functests.execaccess_policies.TestAccessPoliciesSimple) ... ok (0.201s)
  test_access_policies_list (functests.execaccess_policies.TestAccessPoliciesSimple) ... ok (0.579s)
  test_access_policies_update (functests.execaccess_policies.TestAccessPoliciesSimple) ... ok (0.292s)
  test_appidp_token (functests.execapplications.TestApplications) ... ok (0.522s)
  test_appidp_token_404 (functests.execapplications.TestApplications) ... ok (0.323s)
  test_applications_create (functests.execapplications.TestApplications) ... ok (0.252s)
  test_applications_delete (functests.execapplications.TestApplications) ... ok (0.283s)
  test_applications_list (functests.execapplications.TestApplications) ... ok (0.220s)
  test_applications_regenerate (functests.execapplications.TestApplications) ... ok (0.346s)
  test_applications_update (functests.execapplications.TestApplications) ... ok (0.277s)
  test_archivist_token (functests.execapplications.TestApplications) ... skip (0.005s)
  test_asset_create (functests.execassets.TestAssetCreate) ... ok (1.287s)
  test_asset_create_event (functests.execassets.TestAssetCreate) ... ok (1.939s)
  test_asset_create_merkle_log (functests.execassets.TestAssetCreate) ... ok (1.568s)
  test_asset_create_with_fixtures (functests.execassets.TestAssetCreate) ... ok (0.629s)
  test_asset_create_if_not_exists_with_bad_attachment (functests.execassets.TestAssetCreateIfNotExists) ... ok (1.042s)
  test_asset_create_if_not_exists_with_bad_attachment_assetattachment (functests.execassets.TestAssetCreateIfNotExists) ... ok (0.281s)
  test_attachment_info (functests.execattachments.TestAttachmentsCreate) ... skip (0.002s)
  test_attachment_upload_and_download (functests.execattachments.TestAttachmentsCreate) ... ok (0.193s)
  test_attachment_upload_and_download_allow_insecure (functests.execattachments.TestAttachmentsCreate) ... ok (0.184s)
  test_attachment_upload_and_download_docx (functests.execattachments.TestAttachmentsCreate) ... ok (0.204s)
  test_attachment_upload_and_download_strict (functests.execattachments.TestAttachmentsCreate) ... ok (0.182s)
  test_attachment_malware_scan1 (functests.execattachments.TestAttachmentstMalware) ... ok (0.192s)
  test_attachment_malware_scan2 (functests.execattachments.TestAttachmentstMalware) ... ok (0.177s)
  test_attachment_malware_scan3 (functests.execattachments.TestAttachmentstMalware) ... ok (0.204s)
  test_attachment_malware_scan4 (functests.execattachments.TestAttachmentstMalware) ... ok (0.155s)
  test_01_create_artist_albuminfo (functests.execnotebooks.TestNotebooks) ... ok (2.270s)
  test_02_find_artist_create_coverart (functests.execnotebooks.TestNotebooks) ... ok (2.187s)
  test_03_find_artist_addtl_albuminfo (functests.execnotebooks.TestNotebooks) ... ok (1.799s)
  test_create_event_with_verified_domain (functests.execnotebooks.TestNotebooks) ... ok (5.776s)
  test_share_album_release_recordlabel (functests.execnotebooks.TestNotebooks) ... skip (0.002s)
  test_share_album_release_user (functests.execnotebooks.TestNotebooks) ... skip (0.001s)
  test_share_artist_asset_recordlabel (functests.execnotebooks.TestNotebooks) ... skip (0.001s)
  test_share_artist_asset_user (functests.execnotebooks.TestNotebooks) ... skip (0.001s)
  test_asset_create_if_not_exists_with_bad_attachment_assetattachment (functests.execpublicassets.TestPublicAssetCreate) ... ok (31.323s)
  test_public_asset_create (functests.execpublicassets.TestPublicAssetCreate) ... ok (1.144s)
  test_public_asset_create_event (functests.execpublicassets.TestPublicAssetCreate) ... ok (1.649s)
  test_runner_door_entry (functests.execrunner.TestRunner) ... ok (5.629s)
  test_runner_estate_info (functests.execrunner.TestRunner) ... ok (0.287s)
  test_runner_subjects (functests.execrunner.TestRunner) ... ok (0.928s)
  test_runner_synsation (functests.execrunner.TestRunner) ... ok (3.512s)
  test_runner_wipp (functests.execrunner.TestRunner) ... ok (6.095s)
  test_subjects_count (functests.execsubjects.TestSubjects) ... ok (0.138s)
  test_subjects_create (functests.execsubjects.TestSubjects) ... ok (0.166s)
  test_subjects_create_b64 (functests.execsubjects.TestSubjects) ... ok (0.146s)
  test_subjects_delete (functests.execsubjects.TestSubjects) ... ok (0.205s)
  test_subjects_list (functests.execsubjects.TestSubjects) ... ok (0.169s)
  test_subjects_update (functests.execsubjects.TestSubjects) ... ok (0.220s)

----------------------------------------------------------------------
Ran 51 tests in 75.930s

OK (skipped=8)

Generating XML reports...
Generated XML report: ./functest-results/TEST-functests.execaccess_policies.TestAccessPoliciesSimple-20250327172113.xml
Generated XML report: ./functest-results/TEST-functests.execapplications.TestApplications-20250327172113.xml
Generated XML report: ./functest-results/TEST-functests.execassets.TestAssetCreate-20250327172113.xml
Generated XML report: ./functest-results/TEST-functests.execassets.TestAssetCreateIfNotExists-20250327172113.xml
Generated XML report: ./functest-results/TEST-functests.execattachments.TestAttachmentsCreate-20250327172113.xml
Generated XML report: ./functest-results/TEST-functests.execattachments.TestAttachmentstMalware-20250327172113.xml
Generated XML report: ./functest-results/TEST-functests.execnotebooks.TestNotebooks-20250327172113.xml
Generated XML report: ./functest-results/TEST-functests.execpublicassets.TestPublicAssetCreate-20250327172113.xml
Generated XML report: ./functest-results/TEST-functests.execrunner.TestRunner-20250327172113.xml
Generated XML report: ./functest-results/TEST-functests.execsubjects.TestSubjects-20250327172113.xml
Generated XML report: ./functest-results/TEST-functests.execaccess_policies.TestAccessPoliciesShare-20250327172113.xml

AB#10628

@eccles eccles requested a review from j-hartley March 27, 2025 13:34
@eccles eccles force-pushed the dev/paul/10628-remove-compliance-policies branch 5 times, most recently from 87ced6c to 47b470a Compare March 27, 2025 17:15
@eccles eccles marked this pull request as ready for review March 27, 2025 17:24
@eccles eccles force-pushed the dev/paul/10628-remove-compliance-policies branch 3 times, most recently from 7d5bf27 to d8d53bf Compare March 27, 2025 17:50
@eccles
Remove compliance policies
2d539eb 
Add dependabot.yml

Deleted all compliance policies endpoints and tests.
Removed some argument types in the runner as this uses a heterogeneous
dict and it was too difficult to resolve this issue with the pyright
checker.

Removal of the compliance policies exposed some missing runner tests and these
had to be rewritten to obtain 100% coverage.

AB#10628

Signed-off-by: Paul Hewlett <phewlett76@gmail.com>
@eccles eccles force-pushed the dev/paul/10628-remove-compliance-policies branch from d8d53bf to 2d539eb Compare March 27, 2025 17:52
eccles
eccles commented Mar 28, 2025
View reviewed changes
eccles
eccles commented Mar 28, 2025
View reviewed changes
eccles
eccles commented Mar 28, 2025
View reviewed changes
eccles
eccles commented Mar 28, 2025
View reviewed changes
eccles
eccles commented Mar 28, 2025
View reviewed changes
eccles
eccles commented Mar 28, 2025
View reviewed changes
eccles
eccles commented Mar 28, 2025
View reviewed changes
@eccles eccles merged commit 280de9c into main Mar 28, 2025
13 checks passed
@eccles eccles deleted the dev/paul/10628-remove-compliance-policies branch March 28, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@j-hartley j-hartley Awaiting requested review from j-hartley

@robinbryce robinbryce Awaiting requested review from robinbryce

@wp0pw wp0pw Awaiting requested review from wp0pw

@honourfish honourfish Awaiting requested review from honourfish

@landintrees landintrees Awaiting requested review from landintrees

@henry739 henry739 Awaiting requested review from henry739

@rcoxhill-01 rcoxhill-01 Awaiting requested review from rcoxhill-01

1 more reviewer

@waarg waarg waarg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eccles @waarg